Comments (6)
I get that node users prefer this flow, but what would be the benefit?
FWIW, browserify already works since its just a polyfill, not a module with any exported symbols.
from fetch.
If anything, going in the opposite direction would be preferred to me.
We can remove the bower install
dependency from the dev chain and just use curl
to fetch down the polyfill scripts we're depending on. Or just check them in.
from fetch.
How does the test tooling this repo uses affect you're actual application integration of the polyfill?
from fetch.
Replace your shell script test runner with an environment that can run from within node
Maybe you're confused, this polyfill is for running in browser environments, not node. Which is why we want to test in PhantomJS.
from fetch.
Honestly, my suggestions were mainly out of the fact that this is a JS project, that already needs node (for bower, phantom-js, your test environment, etc) and could, via some minor adjustments use that same environment without any need for additional tooling, and work cross platform. Windows and OSX don't have make
and windows doesn't have bash
without additional software... with minor adjustments you could remove those dependencies in favor of a node (already required) solution.
I'm now using browserify
with most of my logic being the same for server (node) and client (browser) rendering, so tools that support both modes of operation and are published in npm are (imho) better than those that aren't. It also is a trend that is seeing a lot of growth.
from fetch.
I'm going to close this out since it's working well so far. I appreciate the suggestion to use more node ecosystem tools, but we can rely on make
being available. The development flow is pretty simple right now.
from fetch.
Related Issues (20)
- <!-- MODIFIED_CONTENT_LINKING_COMMENT -->
- TDTcR8wBLadFYRekvobSSswHaj351EDNRT
- 📢 🎉 We’ve made some exciting improvements to our [REST API documentation](https://docs.github.com/en/rest) and we'd love to know what you think about the new layout! Let us know 👇 HOT 1
- Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the [contributing guidelines](https://github.com/github/docs/blob/main/CONTRIBUTING.md). HOT 1
- This repository is moving from the github org HOT 2
- Owner [email protected]
- 2018 license appachie com [email protected]
- Refused to get unsafe header "set-cookie"
- Owner
- changelog is missing for latest releases HOT 1
- File fetching broken since commit 0c1d2b9 HOT 3
- Create a Security Policy HOT 1
- Enable OpenSSF Scorecard Action HOT 3
- `Set-Cookie` headers should not be combined / Support `Headers.getSetCookie()` method
- Hash pin actions used on workflows and enable depenadabot
- code is working in chrome, not in firefox HOT 2
- Overriding feature detection HOT 1
- suggestion to use str.indexOf(searchString) === 0 for better compatibility HOT 2
- UMD Releases don't exist HOT 1
- Linkedin uses status code 999 which leads to RangeError HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fetch.