Coder Social home page Coder Social logo

Use node ecosystem about fetch HOT 6 CLOSED

jakechampion avatar jakechampion commented on May 18, 2024
Use node ecosystem

from fetch.

Comments (6)

josh avatar josh commented on May 18, 2024

I get that node users prefer this flow, but what would be the benefit?

FWIW, browserify already works since its just a polyfill, not a module with any exported symbols.

from fetch.

josh avatar josh commented on May 18, 2024

If anything, going in the opposite direction would be preferred to me.

We can remove the bower install dependency from the dev chain and just use curl to fetch down the polyfill scripts we're depending on. Or just check them in.

from fetch.

josh avatar josh commented on May 18, 2024

How does the test tooling this repo uses affect you're actual application integration of the polyfill?

from fetch.

josh avatar josh commented on May 18, 2024

Replace your shell script test runner with an environment that can run from within node

Maybe you're confused, this polyfill is for running in browser environments, not node. Which is why we want to test in PhantomJS.

from fetch.

tracker1 avatar tracker1 commented on May 18, 2024

@josh

Honestly, my suggestions were mainly out of the fact that this is a JS project, that already needs node (for bower, phantom-js, your test environment, etc) and could, via some minor adjustments use that same environment without any need for additional tooling, and work cross platform. Windows and OSX don't have make and windows doesn't have bash without additional software... with minor adjustments you could remove those dependencies in favor of a node (already required) solution.

I'm now using browserify with most of my logic being the same for server (node) and client (browser) rendering, so tools that support both modes of operation and are published in npm are (imho) better than those that aren't. It also is a trend that is seeing a lot of growth.

from fetch.

dgraham avatar dgraham commented on May 18, 2024

I'm going to close this out since it's working well so far. I appreciate the suggestion to use more node ecosystem tools, but we can rely on make being available. The development flow is pretty simple right now.

from fetch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.