Coder Social home page Coder Social logo

Comments (6)

pavolloffay avatar pavolloffay commented on August 25, 2024

Can any of these by hadnled by ch sql driver (for instance retries)? Maybe there is some middleware for SQL client that provides these capabilities.

  1. Reload connection string when requested: a user can add new shards to CH installation

Can you please explain this further? Do you mean call sql.Open when the user requests it?

from jaeger-clickhouse.

x4m avatar x4m commented on August 25, 2024

I do not know if drivers do it.
Can you please explain this further? Do you mean call sql.Open when the user requests it?

It's important to handle cases when users change the topology of the CH cluster. Adds or removes nodes. sql.Open() is part of the solution, yes. BTW it's important to reconnect when database was restarted.

from jaeger-clickhouse.

pavolloffay avatar pavolloffay commented on August 25, 2024

It's important to handle cases when users change the topology of the CH cluster. Adds or removes nodes. sql.Open() is part of the solution, yes. BTW it's important to reconnect when database was restarted.

Let's say the DB plugin writes to Distributed table engine and the topology changes (e.g. added new node/shard). Is it mandatory to reconnect to DB with sql.Open? I didn't experience this when working on https://github.com/jaegertracing/jaeger-clickhouse/blob/main/guide-sharding-and-replication.md.

from jaeger-clickhouse.

x4m avatar x4m commented on August 25, 2024

No, it's OK to connect to the remaining nodes. But, I think, eventually you need to update connection information.

from jaeger-clickhouse.

pavolloffay avatar pavolloffay commented on August 25, 2024

Also the storage plugin is connected to the loadbalancer and not to each individual node.

Perhaps we should mention this in our docs. @EinKrebs would you like to document this in the config?

from jaeger-clickhouse.

x4m avatar x4m commented on August 25, 2024

I think in CH each individual node is the load balancer. And you can specify this in the connection string of the driver. But it's better to ask some CH experts here... I'll do that.

from jaeger-clickhouse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.