[jaeger] cmdlineParams uses the wrong format ? about helm-charts

[eddycharly]

@naseemkullah I just tried to quote the 0 and it is working fine. Indeed the if in the template with the 0 was the issue.

Thank you for your help 👍

[eddycharly]

Sure, that’s why I suggested the array approach. It’s usually less error prone.

For exemple, as you don’t quote the value it could be problematic with strings that contain spaces, etc...

[naseemkullah]

Hi @eddycharly it is intended to but there might be a bug, could you display the templated args via helm template ?

[eddycharly]

Sure, the templated args are as follows:

        args:
          - --es.num-shards=2
          - --es.num-replicas=0

How about making cmdlineParams an array instead of a map ? I could simply:

collector:
  cmdlineParams:
    - --es.num-shards
    - '2'
    - --es.num-replicas
    - '0'

[naseemkullah]

Sure, the templated args are as follows:

        args:
          - --es.num-shards=2
          - --es.num-replicas=0

That's weird, I got

        args:
          - --es.num-replicas
          - --es.num-shards=2

which would explain the error you get. Could you try the templating again and double check?

However, in my case if quoting the 0 as "0" in the values file, it does result in the desired:

        args:
          - --es.num-replicas=0
          - --es.num-shards=2

which works.

Although not ideal, I believe that is the workaround we'll have to live with for now, please quote the 0 in your values file and let me know how it goes!

[naseemkullah]

Great!

[naseemkullah]

so we put that if there to accomodate valueless boolean type args @pavelnikolov just thought to keep you up to date, this can have negative consequences for values of 0 for int values such as replica count for es indices