Coder Social home page Coder Social logo

Comments (11)

naseemkullah avatar naseemkullah commented on August 16, 2024 2

Sounds good @mehta-ankit , let's use the cronjob if that's what the operator does. It seems to run es-curator in any case.

from helm-charts.

vkasu-dojo avatar vkasu-dojo commented on August 16, 2024 2

It would be very helpful if we can add support for passing ES_USERNAME & ES_PASSWORD similar to collector deploy and spark cronjob?

from helm-charts.

vkasu-dojo avatar vkasu-dojo commented on August 16, 2024 2

@naseemkullah Raised a PR #65 for adding ES_USERNAME and ES_PASSWORD environment variable to the jaeger-es-index-cleaner job.

from helm-charts.

mehta-ankit avatar mehta-ankit commented on August 16, 2024 1

Also, if we end up deciding on a CronJob, i already have one for my purposes that i am using and can make a PR with that. 👍

from helm-charts.

mehta-ankit avatar mehta-ankit commented on August 16, 2024 1

This PR addresses this issue: #60

from helm-charts.

mehta-ankit avatar mehta-ankit commented on August 16, 2024 1

@naseemkullah Should we just close this issue ?

from helm-charts.

mehta-ankit avatar mehta-ankit commented on August 16, 2024

@naseemkullah Thoughts ?

from helm-charts.

naseemkullah avatar naseemkullah commented on August 16, 2024

That's a great point, we could allow for the creation of https://github.com/helm/charts/tree/master/stable/elasticsearch-curator as a subchart or use the recommended practice of ILM which would be configured in whatever manner the elastic chart recommend. But IMHO there should be no additional template to this jaeger chart.

from helm-charts.

naseemkullah avatar naseemkullah commented on August 16, 2024

On second thought, if jaeger are maintaining an image specifically for this, perhaps we could indeed add it as a cronjob. 🤔

@jpkrohling @yurishkuro Is there a reason operator does not recommend using elastic curator or built int ILM of elasticsearch for index deletion, but resort to a custom tool?

from helm-charts.

naseemkullah avatar naseemkullah commented on August 16, 2024

Yep! Solved via #60

from helm-charts.

naseemkullah avatar naseemkullah commented on August 16, 2024

💯 @venukasu Would you be willing to make a PR to add this?

from helm-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.