[jaeger] Define and implement sidecar injection strategy about helm-charts

[naseemkullah]

First approach would be outside the scope of this chart, and probably not recommended.

Second approach can be achieved as you mentioned but requires adding the container as it was done in query in the deployment spec, and that is outside of this chart.
This second approach is what this issue is about. Having an injector automatically modify the pod as to inject a sidecar based on some annotations would be neat. Something like https://github.com/tumblr/k8s-sidecar-injector maybe. Or see how istio is doing it.

Third approach is indeed covered by this chart.

[TBBle]

I assume this is about Jaeger, since Jaeger Operator already supported this feature when the ticket was opened, per https://www.jaegertracing.io/docs/1.13/operator/#auto-injecting-jaeger-agent-sidecars.

[arpitjindal97]

As far as I know, It totally depends on the developer how he wants to use agent.

• Agent is made to run in same container, so at the time of containerizing the application agent must be configured in Dockerfile

• Second approach can be running application container and agent container in same pod similar to query deployment in this chart.

• Third approach can be using DaemonSet. All applications running in a node will rely on one agent

So, current chart is well configured covering all approaches

[arpitjindal97]

I liked injector approach, We can deploy an injector which will be triggered when an application is deployment based on annotations.

If we go via this approach then we don't have to rely on DaemonSets and doesn't have to mess with yamls also to add agent container. It will be fully automated

[yury-kozlov]

Is this issue about jaeger chart or jaeger-operator chart ?

I'm trying to achieve this behavior with jaeger chart but without success.
However if I use jaeger-operator chart a sidecar is created according to annotation "sidecar.jaegertracing.io/inject": "true".

The problem with operator chart is that it's not flexible enough for my purpose (e.g. doesn't provide option for a static nodeport of jaeger collector).