[jaeger] increase env var flexibility about helm-charts

[arpitjindal97]

I agree with @naseemkullah , extraEnv is quite popular and understandable.

Adding deprecation notice with end of support date will be sufficient.

[Jasstkn]

Hello @naseemkullah! Thanks for asking me, I really appreciate it.

Why we can't combine those approaches?
Let's say all of the env variables will be changed in env: {}, but extraEnvConfig: using toYaml.

If we combine two approaches it will not affect existed installations and upgrade from one version to another. Breaking changes could be really painful for someone.

[cgroschupp]

Hi @Jasstkn, only Values.esIndexCleaner.env and .Values.schema.env are affected. And I think env and extraEnvConfig are very confusing

[naseemkullah]

Yeah to today, on top of es-index-cleaner and schema-job other components using env: {} as it is today are the any storage related env var for all components (i.e. anything beginning with ES_ or CASSANDRA_) ... I'd like to avoid breaking that, but I'd also like avoid having two ways to use env: in the various components of the charts.

So while extraEnvConfig is verbose, the idea is right and extraEnv could be a good way to introduce the improved way to add env vars.

extraEnv has proven to be a widely used var name as per grepping for it in the stable repo: https://github.com/helm/charts/search?p=1&q=extraEnv

Also, extraEnv is actually accurate since we are adding env vars to some others that are added by other means (thats to say, env sounds like it is authorative whereas extraEnv sounds additive)

@cgroschupp @Jasstkn and everyone else WDYT?

[naseemkullah]

Also, we could add alongside env: of the schema, es index cleaner and storage components extraEnv and add a notice in the notes that env: is deprecated in favor of extraEnv and in a few months, get rid of env:.

[mehta-ankit]

I guess i was late to the party 😄
#121 now. 👍

[Jasstkn]

@cgroschupp if I understand correct, @naseemkullah wants to extend this change to all of the environment variables..

[mehta-ankit]

@naseemkullah
I feel having both env and extraEnv is confusing.

I have some questions ?

1. READMe mentions <component>.env - Additional environment variables - {}.
   but i don't see that value (.Values.collector.env or .Values.query.env) being used for other components, like query or collector. Can we not pass in environment variables for those right now?

2. If we use env: {} , How can we use valueForm approach to read from secrets or configMap objects in K8s ?? There are some examples where its helpful: