Fails to download who16? about icd

[nathandalton]

Hi Hans,

I have also had this issue, but believe I have found the cause for some of the errors thrown.

Given the icd package is currently not available on the CRAN respository, I downloaded the most recent version of icd (4.0.9) available from the CRAN archive and installed from source. When running download_all_icd_data(), I encountered the same errors as yourself.

Upon debugging, it appears the error in accessing WHO 2016 is due to a line in the who.R file (which Jack has already fixed here: 450126c)

json_data <- httr::content(http_response, simplifyDataFrame=TRUE)

To the best of my understanding, json_data was not a valid JSON object for manipulation in the next call, resulting in the error 'Error : Argument 'txt' must be a JSON string, URL or file.'.

The following code which Jack has written, however, does provide a fix:

  # encoding not specified by WHO resource (as of 2020-06-06).  Be explicit
  # about assumption.
  json_data <- httr::content(http_response, type = "text", encoding = "UTF-8")

The method I used to edit is as follows:

1. Call options(error=recover). This call assists with stepping through the function causing the problem.
2. Call get_icd10who2016().
3. Select option 9 (i.e. .dl_icd10who_json(year, lang, resource)).
4. Call trace(.dl_icd10who_json, edit = TRUE).
5. In the popup, find the error line from above and replace it with json_data <- httr::content(http_response, type = "text", encoding = "UTF-8") and save.
6. Press Esc.
7. Exit recover mode by calling options(error=NULL).

It appears that this has fixed my problem.

For anyone reading this -- if this method of amending a package that I have used above is not the best way to do so, I would appreciate if you could tell me a better way! I'm relatively new to R, and working with packages is very new to me.

Kind regards,
N