Coder Social home page Coder Social logo

Comments (4)

jacktuck avatar jacktuck commented on May 21, 2024

Just took a very quick look and it appears that website provides an external, relative, link to oembed data.

<link rel="alternate" type="text/xml+oembed" href="./../../../../wp-json/oembed/1.0/embed/index.html?url=.%2F2018%2F04%2F25%2Fthe-winner-take-all-world-of-dental-reviews%2F&#038;format=xml" />

So I think you've uncovered a few issues:

  • We should detect and translate relative urls into absolute ones
  • If an additional lookup for external oembed data fails we shouldn't throw an error because that will mean we can't provide the data which we did manage to pick up such as meta description / title
  • Since we don't handle XML we shouldn't even try to get this data if we know it'll give us xml back

I'll tackle these sometime over the coming days or i'm more than happy to accept a PR if you want to dig around :)

Thanks for reporting 👍

from unfurl.

jacktuck avatar jacktuck commented on May 21, 2024

Actively looking at this just struggling to find time.

from unfurl.

jacktuck avatar jacktuck commented on May 21, 2024

Hi @shaunc869

This should be fixed in the latest major prerelease. You can get it under the beta tag: npm install unfurl.js@beta for now. Schema has changed quite a lot from 1.x.x so you will probably want to give the docs another look.

Nice find btw

from unfurl.

jacktuck avatar jacktuck commented on May 21, 2024

This is the result for the link you provided:

{
    "description": "HighLevel",
    "favicon": "https://www.gohighlevel.com/favicon.ico",
    "keywords": "HighLevel",
    "open_graph": {
        "description": "If you’ve shopped online in the last 5 years you’ve no doubt shopped on Amazon.com, in fact let’s face it we all now shop in Amazon.com, maybe even for our dental equipment. Amazon is fast replacing offline retail for many reasons, it has easy 24/7 access to products, fast 2-day shipping, but it’s real value …",
        "images": [
            {
                "height": 450,
                "url": "https://www.gohighlevel.com/wp-content/uploads/2018/03/amazon-online-review-6797-676x450.jpg",
                "width": 676
            }
        ],
        "locale": "en_US",
        "site_name": "HighLevel",
        "title": "The winner-take-all world of dental reviews - HighLevel",
        "type": "article",
        "url": "https://www.gohighlevel.com/2018/04/25/the-winner-take-all-world-of-dental-reviews/"
    },
    "title": "The winner-take-all world of dental reviews",
    "twitter_card": {
        "card": "summary_large_image",
        "description": "If you’ve shopped online in the last 5 years you’ve no doubt shopped on Amazon.com, in fact let’s face it we all now shop in Amazon.com, maybe even for our dental equipment. Amazon is fast replacing offline retail for many reasons, it has easy 24/7 access to products, fast 2-day shipping, but it’s real value […]",
        "images": [
            {
                "url": "https://www.gohighlevel.com/wp-content/uploads/2018/03/amazon-online-review-6797-676x450.jpg"
            }
        ],
        "title": "The winner-take-all world of dental reviews - HighLevel"
    }
}

It's still a WIP so schema can change in prerelease versions. For instance, keywords there should probably be an array rather than a string!

EDIT:
keywords is fixed now and will be an array

Please ping me if you notice anything else :)

from unfurl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.