Comments (7)
This is a known issue amongst the team - but we hadn't added it here yet. Thanks for adding it.
Just to clarify - it doesn't work on any browser :)
from pair-frontend.
sorry for the slew of issues.
It's great seeing you guys actively working on this.
I'd love to jump in when I get the time
from pair-frontend.
No worries - we appreciate the issues. While we know about all of them, we do forget to add them clearly ourselves sometimes :)
from pair-frontend.
You speak as if you have a means of easy communication within your team.
How would people that want to contribute join that so as to know what needs to be done and where to contribute, etc.?
from pair-frontend.
Most of the communication is handled via the Issues threads and Pull requests on GitHub. Sometimes people reach out to me via the forum or a couple of different Slack groups I'm also in.
Everything that should be discussed properly should be in issues threads though - which works 90% of the time, except for when there are small omissions.
from pair-frontend.
Note that if you try to type in the "Other" field it will give a 400 Bad Request
from the server.
It seems like the setup
property that is send to the server contains the first letter you "input" (invisibly) in the "Other" field.
from pair-frontend.
Selecting "Preferred Technologies" doesn't work either, because it doesn't run handleChange
. This doesn't throw an error, but it simply won't show anything (because it wasn't sent).
I found the error (in case nobody else did it already): The server expects setup
to be an array (which should be created from the "Preferred Technologies", which it doesn't). But the real problem is that the "Other" field also changes setup
. Since the name of the "Other" field is setup
, this is also set as the ID of the input element. Then handleChange
assigns the value (whatever you typed in) to [e.target.id]
(which is setup
). So setup
gets overwritten with a string, instead of an array. The server then returns a 400 Bad Request
and nothing is added.
EDIT: handleChange
doesn't run because the props.handleChange
is not passed into the ModalSelectionList
in ModalForm.js
.
EDIT 2: You can type inside the "Other" field, but since every onChange
updates the state
and therefore refreshes everything, it gets empty every time you type something. The problem is that the value of the "Other" field isn't saved inside the state and manually set to ""
in ModalForm.js
.
I think it is best if the "Other" field gets another name
(and so also another ID). The value of the "Other" field should be kept in the state
(so that it can be updated). The server should than handle another property. It is no problem if the backend isn't updated directly, since it will only skip it, instead of giving an error. Or does the backend check for unknown properties?
from pair-frontend.
Related Issues (20)
- Make the info modal text more relevant HOT 3
- Contributing.md should include reference to Node and NPM HOT 1
- Contributing.md needs to tell contributors how to clone their fork on to their system
- Needs to solve shrinkage of profile photos HOT 4
- Unlimited data can be entered in textboxes HOT 3
- User-cards are added incorrectly HOT 3
- Documentation needed for local development
- Update local config HOT 2
- Create npm script for running local dev without DB
- Deleting post doesn't free its position HOT 6
- Integrate continuous polling for DB data (Wish list!) HOT 6
- Errors are ignored by the frontend
- CSS issues HOT 1
- Can not create new user card HOT 5
- 400 (Bad Request) trying to add card with "new" account? HOT 4
- Can post as other people HOT 4
- Did server port change? HOT 5
- At least one pairing tech should be selected HOT 1
- Audio ping when new card is posted HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pair-frontend.