Coder Social home page Coder Social logo

Comments (3)

emicklei avatar emicklei commented on July 17, 2024
func (p *ConnPool) Close() {
    for i := 0; i < p.maxConnections; i++ {
        if c, err := p.Acquire(); err != nil && c != nil {
            _ = c.Close()
        }
    }
}

from pgx.

jackc avatar jackc commented on July 17, 2024

Thanks. There were actually a couple issues at play. First of all, the check for error on Acquire was backwards. It was only trying to close if there was an error instead of if there wasn't.

Beyond that, if the connection pool was not at maximum capacity, it was establishing connections just so it could release them.

Both of these have now been fixed.

from pgx.

emicklei avatar emicklei commented on July 17, 2024

Thank you for fixing this. Will try the updated package today

from pgx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.