Comments (3)
func (p *ConnPool) Close() {
for i := 0; i < p.maxConnections; i++ {
if c, err := p.Acquire(); err != nil && c != nil {
_ = c.Close()
}
}
}
from pgx.
Thanks. There were actually a couple issues at play. First of all, the check for error on Acquire was backwards. It was only trying to close if there was an error instead of if there wasn't.
Beyond that, if the connection pool was not at maximum capacity, it was establishing connections just so it could release them.
Both of these have now been fixed.
from pgx.
Thank you for fixing this. Will try the updated package today
from pgx.
Related Issues (20)
- Accessing replies in pipeline mode without a sync HOT 3
- Cannot scan into custom composite type (CockroachDB) HOT 1
- Provide improved support for loading types HOT 4
- allow configuring the Config directly, without having to call `ParseConfig` HOT 3
- time.Time and timestamp HOT 5
- panic on scanning to slice of custom types HOT 2
- Interval of 0s is invalid HOT 4
- Add LoadTypes method for bulk type registration HOT 2
- Scan not only anonymous structs HOT 4
- Do not close the connection when the error does not indicate that the connection is broken. HOT 1
- Memory leak in scanPlanString HOT 1
- Support for connections/connstrings that don't require passwords HOT 1
- When using stdlib, Rollback is not sent to DB when transaction context times out HOT 2
- Convert pgtype.Interval to time.Duration HOT 3
- Tracelog uses "time" when logging which can cause issues with JSON payloads HOT 2
- Panic on invalid SSL Key File
- Create `pgtype.Timestamptz` from `time.Time` HOT 3
- `pgtype.Int8.Scan` compares an `int64` with `math.MinInt64` HOT 1
- No error returned from Query (Exec works) HOT 1
- change of tenant for multi tenancy using pgxpool
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pgx.