Coder Social home page Coder Social logo

Comments (9)

j3k0 avatar j3k0 commented on July 24, 2024

Hey @sirflo,

Definitely a good idea. As I'm defining a new unified API that'll support both iOS and Android, I'll make sure unlocalized price and currency find their way into it!

Best!

from cordova-plugin-purchase.

confile avatar confile commented on July 24, 2024

+1

from cordova-plugin-purchase.

sirflo avatar sirflo commented on July 24, 2024

Thanks, that's great news!
I'm looking forward to the new unified API.

from cordova-plugin-purchase.

trancee avatar trancee commented on July 24, 2024

What is the status on this? As for the time being, iOS sends currency:null and adds localized price only...

from cordova-plugin-purchase.

sirflo avatar sirflo commented on July 24, 2024

The pull request/suggestion was for the previous non-unified version of the plugin. I haven't checked if the commit can be applied to the current version (though the changes are minimal).

Have you tried if currency is returning something useful when using the plugin from our old fork? https://github.com/platogo/PhoneGap-InAppPurchase-iOS/tree/currency-code

from cordova-plugin-purchase.

trancee avatar trancee commented on July 24, 2024

Unfortunately, after applying your changes the currency field still returns null. But the price field is now numerical (not localizedPrice).

from cordova-plugin-purchase.

trancee avatar trancee commented on July 24, 2024

I have found out why it didn't work. The problem was that the JavaScript implementation did not pass on the new variables from the iOS / Android native module. After adding those, everything works as expected!

from cordova-plugin-purchase.

robwebdev avatar robwebdev commented on July 24, 2024

I could really do with an unlocalized price for the same reason as the OP.

@j3k0 is there any progress on this? I'd be happy to make an attempt at adding this if you could point me in the right direction.

from cordova-plugin-purchase.

stale avatar stale commented on July 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from cordova-plugin-purchase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.