Exception before redirect about clockwork

[itsgoingd]

Hey, looks like you are firing the "clockwork.controller.end", without firing "clockwork.controller.start" beforehand. Are you using this feature?

[diffmike]

Yes, of course.
Here is my code of BaseController construct:

        $this->beforeFilter('csrf', array('on' => 'post'));

        $this->beforeFilter(function()
        {
            Event::fire('clockwork.controller.start');
        });

        $this->afterFilter(function()
        {
            Event::fire('clockwork.controller.end');
        });

[rdpascua]

I encountered this issue as well, I have this in my BaseController contructor:

    /**
     * Create new instance of BaseController
     */
    public function __construct()
    {
        $this->beforeFilter('csrf', array('on' => 'POST'));
        $this->beforeFilter('auth', ['except' => 'login']);

        $this->beforeFilter(function()
        {
            Event::fire('clockwork.controller.start');
        });

        $this->afterFilter(function()
        {
            Event::fire('clockwork.controller.end');
        });
    }

Well I just solved this by putting first the clockwork events it looks like this:

        $this->beforeFilter(function()
        {
            Event::fire('clockwork.controller.start');
        });

        $this->afterFilter(function()
        {
            Event::fire('clockwork.controller.end');
        });

        $this->beforeFilter('csrf', array('on' => 'POST'));
        $this->beforeFilter('auth', ['except' => 'login']);

[AkenRoberts]

This problem is due to application filters not being registered in the proper order. If I register an App::before() filter in a service provider before Clockwork's service provider is registered, my filter's closure will run before Clockwork. If my filter returns a response, Clockwork's will never be called, thus never calling startEvent().

A solution would be to circumvent registering events using things like $this->app->before(), and target the direct event you want to register a listener for via $this->app['events']->listen() (how it's being done in most places already). Then, you'll also want to specify a priority for, at minimum, the early-on listeners (particularly router.before), which ensures Clockwork's filter(s) run as early as possible, before any user-set listeners.

[diffmike]

thanks!

[AkenRoberts]

@diffmike I would reopen this, as the above solution should be implemented by @itsgoingd / Clockwork, not the user end. I can PR it soon, if desired.

[diffmike]

Ok. It's reopen

[itsgoingd]

Fixed in dev-master, calling endEvent for non-existing event no longer throws exception, as it's not exceptional enough to tear down the whole app imo.

I would like to capture the controller runtime automatically, without the need to add code to the base controller at all, the closest events to use would be afaik router.matched as controller start time and router.after as controller end time, this would still include route filters runtime though. If you have a better idea feel free to reopen.