New hyprland version breaks the plugin (v0.30.0) about hyprland-dwindle-autogroup

[ItsDrike]

Thanks for reporting this, sorry I took longer to notice this, I've been pretty busy lately with uni.

The bisecting here is pretty annoying, since from commit 3785de, there was a typo in Vector2D.hpp file, making the compilation fail, but for a different reason. This was then only fixed in 1925e6, at which point the compilation issue you're encountering was already present.

I wouldn't be surprised if there were other issues in between as well though, as hyprland made a LOT of changes between 0.29.0 and 0.30.0. I will try to fix them all and get the plugin up-to-date with v0.30 though depending on how complex this fix will be, it might be a while until I push a fix for everything.

I'll try keep you up to date though with any progress on this, if it's a simple fix, I might even be able to get it all done today. But otherwise, it might take me a bit longer. In which case, I'd recommend sticking with v0.29.0 until it's fixed.

[ItsDrike]

Should be fixed

[ItsDrike]

Btw, if you have some time, I'd love someone to take a look at #8, not necessarily for a code-review, but at least to "play-test" that it works better, and potentially comment on any bugs you encounter, or any changes you'd like made, to improve the experience.

[chiefdinkan]

Btw, if you have some time, I'd love someone to take a look at #8, not necessarily for a code-review, but at least to "play-test" that it works better, and potentially comment on any bugs you encounter, or any changes you'd like made, to improve the experience.

Sure ! I'll look into it

[chiefdinkan]

Also on the latest git it fails to compile with error

 g++ -shared -g -fPIC --no-gnu-unique -std=c++23 `pkg-config --cflags pixman-1 libdrm hyprland` -Iinclude -DWLR_USE_UNSTABLE src/main.cpp -o dwindle-autogroup.so
In file included from /usr/local/include/hyprland/src/defines.hpp:1,
                 from /usr/local/include/hyprland/src/Window.hpp:3,
                 from src/main.cpp:3:
/usr/local/include/hyprland/src/includes.hpp:108:10: fatal error: wlr/types/wlr_tearing_control_v1.h: No such file or directory
  108 | #include <wlr/types/wlr_tearing_control_v1.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

maybe could be fixed by including the header file (tearing api is introduced recently in hyprland)

[ItsDrike]

I couldn't replicate the compilation issue with latest hyprland. It's possible that this was an issue with hyprland itself, and was fixed in main since. (Possibly here hyprwm/Hyprland@161fee1).

The other option I see here is that you did something weird and didn't copy wlr header files to /usr/local/include during compilation. If this is the case, try compiling normally, by cloning the repo and running sudo make install, it's possible that this is an issue with the PKGBUILD in the AUR, where the copy instructions just didn't contain this for whatever reason (likely vaxry being lazy and not updating the PKGBUILD).

---

However do note that if you wish to use the plugin on latest Hyprland, I encountered another issue, as Hyprland has changed the permissions of the final binary to 711, meaning non-owners (non-root users) will only have the execute permission over the binary, not a read permission.

This causes issues with HyprlandAPI::findFunctionsByName which relies on nm process to read the binary and find a symbol for given function. This plugin uses this function to find the private CHyprDwindleLayout::getNodeFromWindow(CWindow*) function.

As a temporary fix, you can just do sudo chmod o+r $(which Hyprland), making the binary readable to others again. I've already reported this issue on the Hyprland repo though, so hopefully the Makefile will be changed back relatively quickly to fix this. Note that if you're using AUR, this might not affect you at all, since the PKGFILE there should be copying these files manually, so unless vaxry has already updated the permissions there too, you should be fine.

---

If you still can't work it out, consider making a new github issue here, as this one was already marked resolved.