Coder Social home page Coder Social logo

Comments (9)

hzxuzhonghu avatar hzxuzhonghu commented on June 23, 2024 1

It is not limited, but looks https://crates.io/crates/backoff is the most popular one

from ztunnel.

keithmattix avatar keithmattix commented on June 23, 2024

/cc @MorrisLaw

from ztunnel.

MorrisLaw avatar MorrisLaw commented on June 23, 2024

Thank you Keith, I'll look into this!

from ztunnel.

MorrisLaw avatar MorrisLaw commented on June 23, 2024

Is there a retry library that maintainers recommend @howardjohn?

from ztunnel.

MorrisLaw avatar MorrisLaw commented on June 23, 2024

PR is ready for review again: #768

from ztunnel.

MorrisLaw avatar MorrisLaw commented on June 23, 2024

PR has been merged.

from ztunnel.

keithmattix avatar keithmattix commented on June 23, 2024

Had to revert; reopening

from ztunnel.

MorrisLaw avatar MorrisLaw commented on June 23, 2024

Had to revert due to an issue noticed in an automated Istio PR that tried updating to the latest stable ztunnel master. TestIntermediateCertificateRefresh failed due to missing cert. It looks like it wasn't refreshed in time or it could be a possible race condition.

Related areas of the code to look at as it relates to the integration test that were changed before and are relevant to the backoff PR, these may require modification in order to support this change:

Goal is to reproduce the integration test failure with the original PR that has been reverted, then figure out how to update the integration test or the business logic itself so that the integration test no longer fails.

from ztunnel.

MorrisLaw avatar MorrisLaw commented on June 23, 2024

This has been merged back in. Found the issue in an integration test and fixed it. Also, confirmed that istio integration is happy with this latest version of ztunnel: https://github.com/istio/istio/pull/50079/files. We can close this for real now.

from ztunnel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.