Comments (3)
We might want to go one step further by moving the media and file delete function into utils. We have almost identical code here and here.
Further to this there is code in there to delete the translations, but my reading (verified by some experimentation) is that media->delete() and $node->delete() calls drop the translations on their own. Has anyone out there seen cases where translations can linger after a media and file delete?
from documentation.
We might want to go one step further by moving the media and file delete function into utils. We have almost identical code here and here.
I agree. I dislike having such logic in a form submit handler as the same logic defined as a service or similar could be invoked programatically as part of a form submission, or a script, or via API, etc. And having the same logic in two distinct submitForm
s violates DRY.
from documentation.
@ajstanley My suggestion is to create a deleteRepositoryItemsAndMediaAndFiles()
function in Islandora Utils can combine the code from the two examples you mention. I can make a start if you want...
from documentation.
Related Issues (20)
- [DOCS] Paged Content display out of date with Starter site re available contexts HOT 1
- [BUG] Anonymous can't see images in Fedora that use Image Styles. HOT 3
- [DOCS] Evaluate ppa documentation HOT 1
- [DOCS] Document how to deal with bots on live sites HOT 7
- [DOCS] We should have a islandora installation "landing page"
- [BUG] Blocks disappear after being edited because of visibility constraint "node_has_ancestor" HOT 4
- [DOCS] Add link to MIG metadata configuration spreadsheet to official docs HOT 2
- [DOCS] Documentation needed for Islandora Site Template
- [USE CASE] Enable easier testing of PRs/branches by mirroring all Github branches to Gitlab HOT 1
- Add actual image alt text to the Sandbox (Demo Objects). HOT 3
- Drupal 11 Compatibility
- [BUG] Decoration of child/media upload batch processor services fails to (un)serialize inner/decorated service
- [DOCS] Document how to use the official Matomo Docker image with Islandora
- Update testing/compatibility matrices: Drop Drupal 10.1, add 10.4.x-dev.
- [BUG] Drupal 10.3, Image styles that use flysytem (Fedora) are broken again.
- [DOCS] Manual Installation: Recommended Changes to Documentation HOT 5
- [BUG] Database update errors out after updating to Drupal 10.3.1 (solution included) HOT 5
- Incomplete reference on islandora.ca HOT 1
- [DOCS] Provide documentation / configuraiton options to install Islandora (Starter Site) without Fedora integration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from documentation.