Coder Social home page Coder Social logo

Comments (5)

mabedan avatar mabedan commented on June 15, 2024

haven't had a deep look yet, but it seems very good

from jsonhelper.

isair avatar isair commented on June 15, 2024

Hi lancy,

First of all, thanks for taking the time to improve this library. JSONHelper is a library that was started back in the early days of Xcode6-Beta6. The Swift compiler had a very hard time with smart attempts at type conversion and package managers didn't support Swift libraries yet. Therefore, JSONHelper turned out to be a library with lots of repeating code in a single file. I haven't been able to do much other than accept pull requests recently due to my work demanding more and more every day, and I have been wanting to make the code DRY for a long while now. I will check your code in detail this weekend but I like what I see so far. You are welcome to do anything the license permits, which includes altering and redistributing it as long as you mark it as such. However, I'd personally appreciate contributing back to the project more as serialization is also a planned feature for this library (as I have written to you here).

from jsonhelper.

isair avatar isair commented on June 15, 2024

@lancy I have checked your branch in detail, ran the tests, and would love to see a pull request from it so I can go ahead and make it fully backwards compatible then start building the rest of the queued enhancements on top of it.

from jsonhelper.

lancy avatar lancy commented on June 15, 2024

@isair i just created a pull request, check it out :)
btw, Travis CI is not compatible to Swift 1.2, you could use Circle CI https://circleci.com

from jsonhelper.

isair avatar isair commented on June 15, 2024

Thanks for your contribution! A couple of my private projects are using Circle CI and last I checked they still hadn't added Swift 1.2 support. Will check again.

from jsonhelper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.