Coder Social home page Coder Social logo

Memory leak detected about inflight HOT 14 OPEN

isaacs avatar isaacs commented on May 25, 2024 1
Memory leak detected

from inflight.

Comments (14)

milotoor avatar milotoor commented on May 25, 2024 23

Considering the issue has been open 6 years and the inflight.js file has not been edited in 7 years, I think it's likely this isn't going to be addressed here. If your situation is like mine, you are here because Snyk started complaining about this yesterday (why only yesterday? Who knows...) and a package you depend on depends on this package or, more likely, a package you depend on depends on glob which at one point in time depended on inflight. The actively-maintained glob package no longer depends on inflight, so your best bet is to (a) pin your glob version to something greater than v9, (b) to (respectfully) bug package maintainers to upgrade their glob dependency version string, or (c) to ignore the issue because it's probably not doing you real harm anyway. For myself, it's option (c).

from inflight.

tysoncadenhead avatar tysoncadenhead commented on May 25, 2024 5

Can this issue be closed if it's been merged? I'd love to get the warning out of our security scanner

from inflight.

ak-seek avatar ak-seek commented on May 25, 2024 5

We are getting Snyk high issues reported due to this memory leak: https://security.snyk.io/vuln/SNYK-JS-INFLIGHT-6095116

from inflight.

skruzlik avatar skruzlik commented on May 25, 2024 4

Any chance to have this fixed? This package is used all over the place, so it is getting highlighted as a vulnerability almost constantly.

from inflight.

Good-man avatar Good-man commented on May 25, 2024 3

Is this still an issue? I see that a fix was merged but the issue is still open.

from inflight.

JasoonX avatar JasoonX commented on May 25, 2024 3

In our project, we resolved this issue by introducing a pre-installation step that utilizes 'npm-force-resolutions'.
This approach was complemented by adding 'glob' to the 'resolutions' section within our 'package.json'.
This modification effectively enforces the use of a newer version of 'glob'.

package.json

{
  ...
  "scripts": {
    ...
    "preinstall": "npx npm-force-resolutions",
  },
  "resolutions": {
    "glob": "10.3.10"
  }
  ...
}

from inflight.

IdanAdar avatar IdanAdar commented on May 25, 2024 1

Snyk at it again. 🙄

from inflight.

rreeves8 avatar rreeves8 commented on May 25, 2024 1

I've been following this issue, and I can see that it has been open for a considerable amount of time. I understand that addressing memory leak issues can be complex and time-consuming.

I was wondering if there has been any recent progress in resolving this problem. Is there any update or new information that can be shared? I'm interested in staying informed about the current status of the situation.

If there are specific steps to reproduce the problem or any additional information that could help, I'd appreciate the details.

From my understanding the biggest problem is glob version 4 uses this package. Which in turn effects a large number of packages. However glob version 10 no longer uses inflight. So it's just a matter of encouraging package maintainers to update there dependencies to resolve it.

from inflight.

relaxnow avatar relaxnow commented on May 25, 2024

As far as I can see this was not fixed.

Maybe @Good-man saw #5 (reference) and thought it meant a fix was applied?

from inflight.

thetumper avatar thetumper commented on May 25, 2024

Issue and PR in help-me, which resolves transitive issue in pino-pretty:

mcollina/help-me#17
mcollina/help-me#18

Please give a thumbs up there, to help get some priority on it.

from inflight.

adominguezepiuse avatar adominguezepiuse commented on May 25, 2024

I've been following this issue, and I can see that it has been open for a considerable amount of time. I understand that addressing memory leak issues can be complex and time-consuming.

I was wondering if there has been any recent progress in resolving this problem. Is there any update or new information that can be shared? I'm interested in staying informed about the current status of the situation.

If there are specific steps to reproduce the problem or any additional information that could help, I'd appreciate the details.

from inflight.

ramdaniAli avatar ramdaniAli commented on May 25, 2024

using npm-force-resolutions doesn't fundamentally resolve the issue since running npm ls glob may still show that the old, vulnerable version of the glob package is present in your dependency tree. A more robust solution is to leverage the overrides feature in your package.json. By explicitly specifying an override for glob, like this:

{
  ...
  "overrides": {
    "glob": "10.3.10"
  },
  ...
}

You ensure that the specified version of glob is applied throughout your project. However, for this approach to take effect, you will need to perform a fresh installation, you should delete the node_modules folder and the package-lock.json file, and then run npm install. This process forces npm to reinstall all dependencies, taking into account the override you've specified for glob. After doing this, Snyk should no longer report any warnings related to glob, confirming that the chosen version is now in use without any remnants of the old version.

from inflight.

rreeves8 avatar rreeves8 commented on May 25, 2024

using npm-force-resolutions doesn't fundamentally resolve the issue since running npm ls glob may still show that the old, vulnerable version of the glob package is present in your dependency tree. A more robust solution is to leverage the overrides feature in your package.json. By explicitly specifying an override for glob, like this:


{

  ...

  "overrides": {

    "glob": "10.3.10"

  },

  ...

}



You ensure that the specified version of glob is applied throughout your project. However, for this approach to take effect, you will need to perform a fresh installation, you should delete the node_modules folder and the package-lock.json file, and then run npm install. This process forces npm to reinstall all dependencies, taking into account the override you've specified for glob. After doing this, Snyk should no longer report any warnings related to glob, confirming that the chosen version is now in use without any remnants of the old version.

This isn't a robust solution either. Overriding dependency versions can create instability. Each package version is not exactly the same and changing it for every use case will most likely break stuff.

from inflight.

ramdaniAli avatar ramdaniAli commented on May 25, 2024

Certainly, overriding a sub dependency versions carries inherent risks, such as the introduction of unpredictable behavior or a destabilization of system components. Despite these concerns, in my specific situation where glob functions solely as a dependent of argon2, the associated risks are somewhat contained and manageable. At present, our most prudent course of action would be to remain vigilant for updates issued by the argon2 maintainers, in the hope that they will provide a comprehensive solution to the dependency concern.

from inflight.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.