Comments (24)
mcd500
commented on July 23, 2024
My bad. I commited with --amend to fix it.
Please git pull again let me know if it is OK.
from rtptools.
njh
commented on July 23, 2024
Sorry, still not working.
Output from Debian Linux 9.4:
...
make[1]: Entering directory '/home/njh/Projects/rtptools/rtptools-1.22/_build/sub'
( cd '/tmp/am-dc-22948//home/njh/Projects/rtptools/rtptools-1.22/_inst/bin' && rm -f rtpdump rtpplay rtpsend rtptrans )
( cd '/tmp/am-dc-22948//home/njh/Projects/rtptools/rtptools-1.22/_inst/bin' && rm -f multidump multiplay )
( cd '/tmp/am-dc-22948//home/njh/Projects/rtptools/rtptools-1.22/_inst/share/man/man1' && rm -f rtpdump.1 rtpplay.1 rtpsend.1 rtptrans.1 multidump.1 multiplay.1 )
make[1]: Leaving directory '/home/njh/Projects/rtptools/rtptools-1.22/_build/sub'
make[1]: Entering directory '/home/njh/Projects/rtptools/rtptools-1.22/_build/sub'
make[1]: Leaving directory '/home/njh/Projects/rtptools/rtptools-1.22/_build/sub'
make[1]: Entering directory '/home/njh/Projects/rtptools/rtptools-1.22/_build/sub'
make dist-gzip am__post_remove_distdir='@:'
make[2]: Entering directory '/home/njh/Projects/rtptools/rtptools-1.22/_build/sub'
make[2]: *** No rule to make target 'win/*.c', needed by 'distdir'. Stop.
make[2]: Leaving directory '/home/njh/Projects/rtptools/rtptools-1.22/_build/sub'
Makefile:712: recipe for target 'dist' failed
make[1]: *** [dist] Error 2
make[1]: Leaving directory '/home/njh/Projects/rtptools/rtptools-1.22/_build/sub'
Makefile:719: recipe for target 'distcheck' failed
make: *** [distcheck] Error 1
from rtptools.
mcd500
commented on July 23, 2024
The error message is causing the failure.
"make[2]: *** No rule to make target 'win/.c', needed by 'distdir'. Stop."
But I clearly see having 'win/.c' in the github repo and the file downloaded from github.
From both.
"Clone or download" button here
https://github.com/columbia-irt/rtptools
and
git cloning and the command line.
Do you mind teaching me how you downloading the files?
from rtptools.
janstary
commented on July 23, 2024
Please pardon my ignorance: what is make distcheck supposed to do?
from rtptools.
njh
commented on July 23, 2024
make distcheck performs a build, creates a tarball, extracts the tarball and then builds again from that. If there were any tests (unit/integration) then it would also run those make check.
It is very useful to verify no files have been missed out from the distribution and that what you are sending out to the world builds successfully.
More information here:
https://www.gnu.org/software/automake/manual/html_node/Preparing-Distributions.html
from rtptools.
mcd500
commented on July 23, 2024
From your error message, I started to suspect using star wildcard in EXTRA_DIST causing the error.
Let me have a quick check.
from rtptools.
mcd500
commented on July 23, 2024
It was the star wildcard and it is fixed on
aeaa8dc
This fix might not necessary when we introduce the new configure file but I just wanted to learn it from your comment.
I was normally running make dist and make check separately.
And the rtptools do not have test programs yet.
I will use the make distcheck when I have chance to make release with autotools.
from rtptools.
janstary
commented on July 23, 2024
The lists in the Makefile should never use wildcards (that's e.g. how *sdf got into the tree).
It knows the list of files in advance.
from rtptools.
janstary
commented on July 23, 2024
make distcheck added to the new build in https://github.com/janstary/rtptools/commit/834b78ff2f815fdc4da619ff664ae37d93cb460c
from rtptools.
janstary
commented on July 23, 2024
The new build system is in; can you please check on your system?
from rtptools.
njh
commented on July 23, 2024
Confirmed no errors in the new build system:
~/Projects/rtptools(master) $ make distclean
rm -f rtptools-1.23.tar.gz rtpdump rtpplay rtpsend rtptrans hpt.o host2ip.o rd.o rtpdump.o hpt.o host2ip.o notify.o multimer.o rd.o rtpplay.o hpt.o host2ip.o notify.o multimer.o rtpsend.o hpt.o host2ip.o notify.o multimer.o rtptrans.o compat_err.o compat_strtonum.o multidump.1.html multiplay.1.html rtpdump.1.html rtpplay.1.html rtpsend.1.html rtptrans.1.html
rm -rf rtptools-1.23 win/include
rm -rf *.dSYM *.core *~ .*~
rm -f Makefile.local config.h config.h.old config.log config.log.old
~/Projects/rtptools(master) $ ./configure
config.log: writing...
configure.local: no (fully automatic configuration)
gethostbyname-lnsl: no
msgcontrol: yes
socket-lsocket: no
config.h: written
Makefile.local: written
~/Projects/rtptools(master) $ make distcheck
mkdir -p win/include/{arpa,netinet,sys}
touch win/include/arpa/inet.h
mkdir -p win/include/{arpa,netinet,sys}
touch win/include/netdb.h
mkdir -p win/include/{arpa,netinet,sys}
touch win/include/netinet/in.h
mkdir -p win/include/{arpa,netinet,sys}
touch win/include/sys/select.h
mkdir -p win/include/{arpa,netinet,sys}
touch win/include/sys/socket.h
mkdir -p win/include/{arpa,netinet,sys}
touch win/include/sys/time.h
mkdir -p win/include/{arpa,netinet,sys}
touch win/include/sys/uio.h
mkdir -p win/include/{arpa,netinet,sys}
touch win/include/unistd.h
rm -rf .dist
mkdir -p .dist/rtptools-1.23/
install -m 0644 LICENSE Makefile Makefile.depend bark.rtp configure configure.local.example ChangeLog.html multidump.1 multiplay.1 rtpdump.1 rtpplay.1 rtpsend.1 rtptrans.1 multidump multiplay ansi.h host2ip.c hpt.c hsearch.c hsearch.h multimer.c multimer.h notify.c notify.h rd.c rtp.h rtpdump.c rtpdump.h rtpplay.c rtpsend.c rtptrans.c sysdep.h vat.h have-err.c have-gethostbyname.c have-strtonum.c have-msgcontrol.c .dist/rtptools-1.23/
cp -r win .dist/rtptools-1.23/
( cd .dist/rtptools-1.23 && chmod 755 configure multidump multiplay )
( cd .dist && tar czf ../rtptools-1.23.tar.gz rtptools-1.23 )
rm -rf .dist/
rm -rf rtptools-1.23 && tar xzf rtptools-1.23.tar.gz
( cd rtptools-1.23 && ./configure && make all )
config.log: writing...
configure.local: no (fully automatic configuration)
gethostbyname-lnsl: no
msgcontrol: yes
socket-lsocket: no
config.h: written
Makefile.local: written
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c hpt.c
hpt.c:44:5: warning: no previous prototype for function 'hpt'
[-Wmissing-prototypes]
int hpt(char *h, struct sockaddr *sa, unsigned char *ttl)
^
1 warning generated.
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c host2ip.c
host2ip.c:43:16: warning: no previous prototype for function 'host2ip'
[-Wmissing-prototypes]
struct in_addr host2ip(char *host)
^
host2ip.c:52:42: warning: comparison of integers of different signs: 'in_addr_t'
(aka 'unsigned int') and 'int' [-Wsign-compare]
else if ((in.s_addr = inet_addr(host)) != -1) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~
2 warnings generated.
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c rd.c
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c rtpdump.c
rtpdump.c:114:11: warning: passing 'const char [1]' to parameter of type
'char *' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
usage("");
^~
rtpdump.c:66:25: note: passing argument to parameter 'argv0' here
static void usage(char *argv0)
^
rtpdump.c:119:11: warning: passing 'const char [1]' to parameter of type
'char *' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
usage("");
^~
rtpdump.c:66:25: note: passing argument to parameter 'argv0' here
static void usage(char *argv0)
^
rtpdump.c:117:28: warning: comparison of integers of different signs:
'in_addr_t' (aka 'unsigned int') and 'int' [-Wsign-compare]
if (sin->sin_addr.s_addr == -1) {
~~~~~~~~~~~~~~~~~~~~ ^ ~~
rtpdump.c:219:12: warning: returning 'const char *' from a function with result
type 'char *' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
return r->version == RTP_VERSION ? "RTP" : "VATD";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
rtpdump.c:223:12: warning: returning 'const char *' from a function with result
type 'char *' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
return r->common.version == RTP_VERSION ? "RTCP" : "VATC";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
rtpdump.c:289:43: warning: format specifies type 'unsigned long' but the
argument has type 'uint32_t' (aka 'unsigned int') [-Wformat]
fprintf(out, "csrc[%d]=0x%0lx ", i, r->csrc[i]);
~~~~ ^~~~~~~~~~
%0x
rtpdump.c:322:46: warning: format specifies type 'long' but the argument has
type '__darwin_suseconds_t' (aka 'int') [-Wformat]
(v->flags ? -now.tv_sec : now.tv_sec), now.tv_usec,
^~~~~~~~~~~
rtpdump.c:327:42: warning: format specifies type 'long' but the argument has
type '__darwin_suseconds_t' (aka 'int') [-Wformat]
(r->m ? -now.tv_sec : now.tv_sec), now.tv_usec,
^~~~~~~~~~~
rtpdump.c:345:24: warning: initializing 'char *' with an expression of type
'const char [4]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{RTCP_SDES_END, "end"},
^~~~~
rtpdump.c:346:24: warning: initializing 'char *' with an expression of type
'const char [6]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{RTCP_SDES_CNAME, "CNAME"},
^~~~~~~
rtpdump.c:347:24: warning: initializing 'char *' with an expression of type
'const char [5]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{RTCP_SDES_NAME, "NAME"},
^~~~~~
rtpdump.c:348:24: warning: initializing 'char *' with an expression of type
'const char [6]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{RTCP_SDES_EMAIL, "EMAIL"},
^~~~~~~
rtpdump.c:349:24: warning: initializing 'char *' with an expression of type
'const char [6]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{RTCP_SDES_PHONE, "PHONE"},
^~~~~~~
rtpdump.c:350:24: warning: initializing 'char *' with an expression of type
'const char [4]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{RTCP_SDES_LOC, "LOC"},
^~~~~
rtpdump.c:351:24: warning: initializing 'char *' with an expression of type
'const char [5]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{RTCP_SDES_TOOL, "TOOL"},
^~~~~~
rtpdump.c:352:24: warning: initializing 'char *' with an expression of type
'const char [5]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{RTCP_SDES_NOTE, "NOTE"},
^~~~~~
rtpdump.c:353:24: warning: initializing 'char *' with an expression of type
'const char [5]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{RTCP_SDES_PRIV, "PRIV"},
^~~~~~
rtpdump.c:354:24: warning: initializing 'char *' with an expression of type
'const char [7]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{11, "SOURCE"},
^~~~~~~~
rtpdump.c:339:6: warning: no previous prototype for function 'member_sdes'
[-Wmissing-prototypes]
void member_sdes(FILE *out, member_t m, rtcp_sdes_type_t t, char *b, int len)
^
rtpdump.c:581:29: warning: format specifies type 'long' but the argument has
type '__darwin_suseconds_t' (aka 'int') [-Wformat]
now.tv_sec, now.tv_usec, parse_type(ctrl, packet->p.data),
^~~~~~~~~~~
rtpdump.c:594:29: warning: format specifies type 'long' but the argument has
type '__darwin_suseconds_t' (aka 'int') [-Wformat]
now.tv_sec, now.tv_usec, parse_type(ctrl, packet->p.data),
^~~~~~~~~~~
rtpdump.c:527:6: warning: no previous prototype for function 'packet_handler'
[-Wmissing-prototypes]
void packet_handler(FILE *out, t_format format, int trunc,
^
rtpdump.c:613:6: warning: initializing 'char *' with an expression of type
'const char [5]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"dump", F_dump},
^~~~~~
rtpdump.c:614:6: warning: initializing 'char *' with an expression of type
'const char [7]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"header", F_header},
^~~~~~~~
rtpdump.c:615:6: warning: initializing 'char *' with an expression of type
'const char [4]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"hex", F_hex},
^~~~~
rtpdump.c:616:6: warning: initializing 'char *' with an expression of type
'const char [5]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"rtcp", F_rtcp},
^~~~~~
rtpdump.c:617:6: warning: initializing 'char *' with an expression of type
'const char [6]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"short", F_short},
^~~~~~~
rtpdump.c:618:6: warning: initializing 'char *' with an expression of type
'const char [8]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"payload", F_payload},
^~~~~~~~~
rtpdump.c:619:6: warning: initializing 'char *' with an expression of type
'const char [6]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"ascii", F_ascii},
^~~~~~~
rtpdump.c:713:20: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[i].enc = "????";
^ ~~~~~~
rtpdump.c:720:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 0].enc = "PCMU"; pt_map[ 0].rate = 8000; pt_map[ 0].ch = 1;
^ ~~~~~~
rtpdump.c:721:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 1].enc = "1016"; pt_map[ 1].rate = 8000; pt_map[ 1].ch = 1;
^ ~~~~~~
rtpdump.c:722:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 2].enc = "G721"; pt_map[ 2].rate = 8000; pt_map[ 2].ch = 1;
^ ~~~~~~
rtpdump.c:723:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 3].enc = "GSM "; pt_map[ 3].rate = 8000; pt_map[ 3].ch = 1;
^ ~~~~~~
rtpdump.c:724:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 4].enc = "G723"; pt_map[ 4].rate = 8000; pt_map[ 4].ch = 1;
^ ~~~~~~
rtpdump.c:725:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 5].enc = "DVI4"; pt_map[ 5].rate = 8000; pt_map[ 5].ch = 1;
^ ~~~~~~
rtpdump.c:726:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 6].enc = "DVI4"; pt_map[ 6].rate = 16000; pt_map[ 6].ch = 1;
^ ~~~~~~
rtpdump.c:727:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 7].enc = "LPC "; pt_map[ 7].rate = 8000; pt_map[ 7].ch = 1;
^ ~~~~~~
rtpdump.c:728:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 8].enc = "PCMA"; pt_map[ 8].rate = 8000; pt_map[ 8].ch = 1;
^ ~~~~~~
rtpdump.c:729:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 9].enc = "G722"; pt_map[ 9].rate = 8000; pt_map[ 9].ch = 1;
^ ~~~~~~
rtpdump.c:730:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 10].enc = "L16 "; pt_map[ 10].rate = 44100; pt_map[ 10].ch = 2;
^ ~~~~~~
rtpdump.c:731:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 11].enc = "L16 "; pt_map[ 11].rate = 44100; pt_map[ 11].ch = 1;
^ ~~~~~~
rtpdump.c:732:19: warning: assigning to 'char *' from 'const char [6]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 12].enc = "QCELP"; pt_map[ 12].rate = 8000; pt_map[ 12].ch = 1;
^ ~~~~~~~
rtpdump.c:733:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 14].enc = "MPA "; pt_map[ 14].rate = 90000; pt_map[ 14].ch = 0;
^ ~~~~~~
rtpdump.c:734:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 15].enc = "G728"; pt_map[ 15].rate = 8000; pt_map[ 15].ch = 1;
^ ~~~~~~
rtpdump.c:735:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 16].enc = "DVI4"; pt_map[ 16].rate = 11025; pt_map[ 16].ch = 1;
^ ~~~~~~
rtpdump.c:736:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 17].enc = "DVI4"; pt_map[ 17].rate = 22050; pt_map[ 17].ch = 1;
^ ~~~~~~
rtpdump.c:737:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 18].enc = "G729"; pt_map[ 18].rate = 8000; pt_map[ 18].ch = 1;
^ ~~~~~~
rtpdump.c:738:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 23].enc = "SCR "; pt_map[ 23].rate = 90000; pt_map[ 23].ch = 0; /*r*/
^ ~~~~~~
rtpdump.c:739:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 24].enc = "MPEG"; pt_map[ 24].rate = 90000; pt_map[ 24].ch = 0; /*r*/
^ ~~~~~~
rtpdump.c:740:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 25].enc = "CelB"; pt_map[ 25].rate = 90000; pt_map[ 25].ch = 0;
^ ~~~~~~
rtpdump.c:741:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 26].enc = "JPEG"; pt_map[ 26].rate = 90000; pt_map[ 26].ch = 0;
^ ~~~~~~
rtpdump.c:742:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 27].enc = "CUSM"; pt_map[ 27].rate = 90000; pt_map[ 27].ch = 0; /*r*/
^ ~~~~~~
rtpdump.c:743:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 28].enc = "nv "; pt_map[ 28].rate = 90000; pt_map[ 28].ch = 0;
^ ~~~~~~
rtpdump.c:744:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 29].enc = "PicW"; pt_map[ 29].rate = 90000; pt_map[ 29].ch = 0; /*r*/
^ ~~~~~~
rtpdump.c:745:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 30].enc = "CPV "; pt_map[ 30].rate = 90000; pt_map[ 30].ch = 0; /*r*/
^ ~~~~~~
rtpdump.c:746:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 31].enc = "H261"; pt_map[ 31].rate = 90000; pt_map[ 31].ch = 0;
^ ~~~~~~
rtpdump.c:747:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 32].enc = "MPV "; pt_map[ 32].rate = 90000; pt_map[ 32].ch = 0;
^ ~~~~~~
rtpdump.c:748:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 33].enc = "MP2T"; pt_map[ 33].rate = 90000; pt_map[ 33].ch = 0;
^ ~~~~~~
rtpdump.c:749:19: warning: assigning to 'char *' from 'const char [5]' discards
qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
pt_map[ 34].enc = "H263"; pt_map[ 34].rate = 90000; pt_map[ 34].ch = 0;
^ ~~~~~~
60 warnings generated.
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -o rtpdump hpt.o host2ip.o rd.o rtpdump.o
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c notify.c
notify.c:67:6: warning: no previous prototype for function 'check_clr_fd'
[-Wmissing-prototypes]
void check_clr_fd(void)
^
notify.c:137:13: warning: no previous prototype for function
'notify_set_itimer_func' [-Wmissing-prototypes]
Notify_func notify_set_itimer_func(
^
notify.c:204:63: warning: format specifies type 'unsigned long' but the argument
has type '__darwin_suseconds_t' (aka 'int') [-Wformat]
fprintf(stderr, "Timeout: %lu.%06lu\n", timeout.tv_sec, timeout.tv_usec);
~~~~~ ^~~~~~~~~~~~~~~
%06d
3 warnings generated.
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c multimer.c
multimer.c:91:6: warning: no previous prototype for function 'timer_check'
[-Wmissing-prototypes]
void timer_check(void)
^
multimer.c:115:17: warning: no previous prototype for function 'timer_set'
[-Wmissing-prototypes]
struct timeval *timer_set(struct timeval *interval,
^
multimer.c:187:17: warning: no previous prototype for function 'timer_get'
[-Wmissing-prototypes]
struct timeval *timer_get(struct timeval *timeout)
^
multimer.c:227:5: warning: no previous prototype for function 'timer_pending'
[-Wmissing-prototypes]
int timer_pending(void)
^
4 warnings generated.
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c rtpplay.c
rtpplay.c:354:52: warning: passing 'char *' to parameter of type
'unsigned char *' converts between pointers to integer types with
different sign [-Wpointer-sign]
if (hpt(argv[optind], (struct sockaddr *)&sin, &ttl) < 0) {
^~~~
rtpplay.c:310:63: note: passing argument to parameter 'ttl' here
extern int hpt(char *h, struct sockaddr *sa, unsigned char *ttl);
^
rtpplay.c:358:29: warning: comparison of integers of different signs:
'in_addr_t' (aka 'unsigned int') and 'int' [-Wsign-compare]
if (sin.sin_addr.s_addr == -1) {
~~~~~~~~~~~~~~~~~~~ ^ ~~
2 warnings generated.
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -o rtpplay hpt.o host2ip.o notify.o multimer.o rd.o rtpplay.o
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c rtpsend.c
rtpsend.c:240:6: warning: initializing 'char *' with an expression of type
'const char [4]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"end", RTCP_SDES_END},
^~~~~
rtpsend.c:241:6: warning: initializing 'char *' with an expression of type
'const char [6]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"cname", RTCP_SDES_CNAME},
^~~~~~~
rtpsend.c:242:6: warning: initializing 'char *' with an expression of type
'const char [5]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"name", RTCP_SDES_NAME},
^~~~~~
rtpsend.c:243:6: warning: initializing 'char *' with an expression of type
'const char [6]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"email", RTCP_SDES_EMAIL},
^~~~~~~
rtpsend.c:244:6: warning: initializing 'char *' with an expression of type
'const char [6]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"phone", RTCP_SDES_PHONE},
^~~~~~~
rtpsend.c:245:6: warning: initializing 'char *' with an expression of type
'const char [4]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"loc", RTCP_SDES_LOC},
^~~~~
rtpsend.c:246:6: warning: initializing 'char *' with an expression of type
'const char [5]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"tool", RTCP_SDES_TOOL},
^~~~~~
rtpsend.c:247:6: warning: initializing 'char *' with an expression of type
'const char [5]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"note", RTCP_SDES_NOTE},
^~~~~~
rtpsend.c:248:6: warning: initializing 'char *' with an expression of type
'const char [5]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{"priv", RTCP_SDES_PRIV},
^~~~~~
rtpsend.c:401:7: warning: no previous prototype for function 'usec2ntp'
[-Wmissing-prototypes]
u_int usec2ntp(u_int usec)
^
rtpsend.c:599:7: warning: initializing 'char *' with an expression of type
'const char [5]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{ "SDES", rtcp_write_sdes },
^~~~~~
rtpsend.c:600:7: warning: initializing 'char *' with an expression of type
'const char [3]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{ "RR", rtcp_write_rr },
^~~~
rtpsend.c:601:7: warning: initializing 'char *' with an expression of type
'const char [3]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{ "SR", rtcp_write_sr },
^~~~
rtpsend.c:602:7: warning: initializing 'char *' with an expression of type
'const char [4]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{ "BYE", rtcp_write_bye },
^~~~~
rtpsend.c:603:7: warning: initializing 'char *' with an expression of type
'const char [4]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
{ "APP", rtcp_write_app },
^~~~~
rtpsend.c:802:24: warning: missing field 'data' initializer
[-Wmissing-field-initializers]
} packet = { 0, -1, 0};
^
rtpsend.c:918:52: warning: passing 'char *' to parameter of type
'unsigned char *' converts between pointers to integer types with
different sign [-Wpointer-sign]
if (hpt(argv[optind], (struct sockaddr *)&sin, &ttl) < 0) {
^~~~
rtpsend.c:877:63: note: passing argument to parameter 'ttl' here
extern int hpt(char *h, struct sockaddr *sa, unsigned char *ttl);
^
rtpsend.c:922:29: warning: comparison of integers of different signs:
'in_addr_t' (aka 'unsigned int') and 'int' [-Wsign-compare]
if (sin.sin_addr.s_addr == -1) {
~~~~~~~~~~~~~~~~~~~ ^ ~~
18 warnings generated.
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -o rtpsend hpt.o host2ip.o notify.o multimer.o rtpsend.o
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c rtptrans.c
rtptrans.c:93:5: warning: no previous prototype for function 'create_stream'
[-Wmissing-prototypes]
int create_stream(int addr, int next)
^
rtptrans.c:149:5: warning: no previous prototype for function 'find_stream'
[-Wmissing-prototypes]
int find_stream(int addr, int ts, int next, int m)
^
rtptrans.c:318:49: warning: comparison of integers of different signs: 'ssize_t'
(aka 'long') and 'unsigned long' [-Wsign-compare]
if ((sendmsg(side[i][2].sock, &msg,0))!=
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
rtptrans.c:388:6: warning: no previous prototype for function 'usage'
[-Wmissing-prototypes]
void usage(char *argv0)
^
rtptrans.c:461:37: warning: comparison of integers of different signs:
'in_addr_t' (aka 'unsigned int') and 'int' [-Wsign-compare]
if (host[i].sin.sin_addr.s_addr == -1) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~
5 warnings generated.
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -o rtptrans hpt.o host2ip.o notify.o multimer.o rtptrans.o
~/Projects/rtptools(master) $ echo $?
0
from rtptools.
njh
commented on July 23, 2024
Re-opening because it is failing on Linux:
https://travis-ci.org/njh/rtptools/builds/359033377
from rtptools.
janstary
commented on July 23, 2024
Thanks for checking.
If it cannot touch win/include/arpa/inet.h then I suppose the previous
mkdir -p win/include/{arpa,netinet,sys} has failed, i.e. has not created
the win/include/arpa/ directory. Perhaps it craeted, literaly, {arpa,netinet,sys}.
Anyway, the real fix is to stop doing this. We create and distribute empty files,
which is silly. Let me prepare a PR.
from rtptools.
janstary
commented on July 23, 2024
Nicholas, can you please check with #64 ?
from rtptools.
janstary
commented on July 23, 2024
#64 does something else now,
but at any rate it should also fix the breakage described here.
from rtptools.
janstary
commented on July 23, 2024
@njh Can you please verify that this fixes your problem?
from rtptools.
njh
commented on July 23, 2024
Yup, make distcheck is working on my own Debian Linux box.
The Travis build is working too: https://travis-ci.org/njh/rtptools/builds/359993537
from rtptools.
janstary
commented on July 23, 2024
That builds master. Is there a way in Travis to build other branches too? Thanks.
from rtptools.
janstary
commented on July 23, 2024
Looks like Travis needs to be enabled for the columbia-irt Github account:
https://travis-ci.org/columbia-irtgives me
We couldn't find the owner columbia-irt
What's the admin thing to do now?
Akira, can you please enable Travis for columbia-irt?
(Not that I know what exactly that means.)
What other OSes can we have to test on in Travis?
from rtptools.
mcd500
commented on July 23, 2024
@janstary I tried to enable the Travis.
#52 (comment)
The Travis seems to need to be enabled by who created https://github.com/columbia-irt.
@janakj, is it possible for you?
from rtptools.
njh
commented on July 23, 2024
Sorry, I was commenting about Travis on the Travis CI PR tickets.
It looks like 'columbia-irt' is an Organisation?
If so, I think any of the Organisation admins should be able to enable Travis for a repo that belongs to columbia-irt.
@janstary Yes, Travis can build Branches, not just master.
It can also automatically build PRs and report the build success - so you know before merging.
See #77 for a list of OSes that Travis supports. Not very many - I believe there are other Continuous Integration providers that support more.
from rtptools.
janakj
commented on July 23, 2024
I enabled Travis for the rtptools repository. Please give it a try and email me if it still does not work.
from rtptools.
mcd500
commented on July 23, 2024
@janakj thanks!
https://travis-ci.org/njh/rtptools
from rtptools.
njh
commented on July 23, 2024
Doesn't seem to have worked. I have raised #103
from rtptools.
Related Issues (20)
- Enable Travis CI for the columbia-irt/rtptools repository HOT 4
- rtpdump: the port number is added by one HOT 1
- verbose option not working on rtpdump
- rtpdump: uninitialized value of start in RD_hdr_t will be written when reading from a file HOT 1
- Centos 7 source rpm build fails with /usr/bin ... conflicts with file from package filesystem... HOT 2
- connect: Address family not supported by protocol family HOT 2
- rtpsend: "Line ???? is invalid" HOT 2
- RTP Tools website offline? HOT 1
- RTPDump to file
- winsock HOT 8
- Mac OS build is failing due to ACTION macro problems HOT 3
- config.h is not included with make dist, failes to build on Windows HOT 2
- make depend fails, CentOS, Fedora do not have mkdep HOT 2
- Get rtptools added to Debian
- make rpm is not working at the moment HOT 5
- RFC: moving getopt() to compat-* HOT 5
- rtptrans: uses ipv4 address for SSRC in RTP header HOT 1
- rtpdump segfaults HOT 1
- use even-numbered ports for RTP HOT 2
- build fails on win for 'err.h' HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rtptools.