Coder Social home page Coder Social logo

Comments (3)

giarc3 avatar giarc3 commented on August 17, 2024

I believe the intended distinction is that None comes back from admin_list, member_list, and owner if you aren't a member/admin of the group. But this should definitely be documented better.

from ironoxide.

BobWall23 avatar BobWall23 commented on August 17, 2024

Currently, the group permissions include is_admin and is_member - if both are false, you can't get any information about the group admins and members. So this information is somewhat redundant with the none Option for the admin / member lists.

Getting rid of the Option around the vecs gets rid of an extra layer of unwrapping in the consumer, which seems good. We would put this in a v2 ironoxide API feature branch. Not needed any time soon - we can accumulate things in the feature branch until we have enough to release.

from ironoxide.

skeet70 avatar skeet70 commented on August 17, 2024

@coltfred brought up that we could return an enum type of the GroupMeta and GroupFull types with an impl that lets you use the things that will always be there, and you could match if you need to use something that might not be there (owner or needs_rotation).

from ironoxide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.