Coder Social home page Coder Social logo

changelog.md about body-parser HOT 13 CLOSED

iron avatar iron commented on June 3, 2024
changelog.md

from body-parser.

Comments (13)

e-oz avatar e-oz commented on June 3, 2024 1

You are right about semver rules. It's just young age of Rust ecosystem in general - using it is a living on the edge :)

from body-parser.

e-oz avatar e-oz commented on June 3, 2024

Thanks for reply. Not sure how it's supposed to use in production, if Serde is not in beta and will not be there in foreseen future.

from body-parser.

untitaker avatar untitaker commented on June 3, 2024

Serde can be used in stable Rust with a build script, but you can also use it without codegen and therefore without build script. No idea what you mean with "not in beta".

I don't see sense in adding a changelog before 1.0.

from body-parser.

e-oz avatar e-oz commented on June 3, 2024

Serde can't be even compiled in beta/stable.
By "not in beta" I mean not in non-nightly branch.
By semver rules breaking changes should increment major number of version, so I asked at least document breaking changes, if changing version is not desirable by some reasons.

from body-parser.

untitaker avatar untitaker commented on June 3, 2024

Serde can't be even compiled in beta/stable.

It does compile on my machine and Travis.

By semver rules breaking changes should increment major number of version

I agree. Where did you see this violated?

from body-parser.

untitaker avatar untitaker commented on June 3, 2024

Also, please spare your passive-aggressive tone and rather consider that I'm doing this in my freetime. I'm not customer service.

from body-parser.

e-oz avatar e-oz commented on June 3, 2024

Try to add some usage code and it will not compile.
Breaking change is pretty simple: I use bodyparser 0.0.6 and rustc-serialize and my structures are annotated for it. Upgrade to latest bodyparser breaks compilation.

from body-parser.

e-oz avatar e-oz commented on June 3, 2024

It's not agressive tone, it's just annoyed by "work on my machine"-style responses. Thank you very much for your work, hope this issue will be useful for somebody else also.

from body-parser.

untitaker avatar untitaker commented on June 3, 2024

Try to add some usage code and it will not compile.

The examples are tested for each commit in Travis. Those are usage code. What are you talking about?

It's not just "works on my machine", it's "it works on Travis, my machine and apparently for everybody else". Therefore I'm also a bit annoyed when you imply that this crate is broken in some obvious way.

Breaking change is pretty simple:

I think you misunderstand how semver works. Before 1.0, every 0.x release is allowed to contain breaking changes. See http://semver.org/#spec-item-4, but it's common practice to not do any breakage on PATCH releases (only on MINOR).

You need to set version to "x.y" in your Cargo.toml to avoid accidental upgrading to a non-compatible version.

from body-parser.

untitaker avatar untitaker commented on June 3, 2024

Sorry, actually there's only nightly tests in Travis. I've now added stable, but those are IMO unlikely to fail. Serde itself does have such tests.

from body-parser.

e-oz avatar e-oz commented on June 3, 2024

If traits of Serde (serialize/desirialize) are not derived by structs, it obviously will not compile. That's what I've tried to describe.
I think we both loosing time in this arguing, let's just close and my experience will be only my experience.
Sorry for inconveniences.

from body-parser.

untitaker avatar untitaker commented on June 3, 2024

If traits of Serde (serialize/desirialize) are not derived by structs, it obviously will not compile. That's what I've tried to describe.

Okay, but that's just the "breaking change" part... as said, it's covered by the version scheme though.

I'm rather open-minded about a changelog, but it's extra work. I don't know if anybody wants to do this work if Iron in general is already a bit undermaintained.

from body-parser.

Hoverbear avatar Hoverbear commented on June 3, 2024

I'd note that according to semver as long as the version major is 0.x.x any change is allowed to be breaking.

from body-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.