Capture `screenshot` events about ipfs-desktop

[daviddias]

It should not be enabled by default and if enabled, it should let the user pick a custom key shortcut for it to activate.

[jbenet]

📷 🌆 👍

[whyrusleeping]

that seems sketchy to me..

[jbenet]

that seems sketchy to me..

why?

[whyrusleeping]

we're going to capture every single screenshot someone takes on their computer? maybe as like an extreme multiclick opt in... but otherwise that seems a bit invasive.

[daviddias]

@whyrusleeping other apps are currently doing that, as an opt-in of course. We can have a special keyboard shortcut for ipfs screenshots, but capturing the natural events from the events is more convenient to the user (+ Mac OS screenshots are really cool)

[jbenet]

we're going to capture every single screenshot someone takes on their computer?

oh what, somehow i missed that. @diasdavid i think that's pretty sketchy. we can allow the user to change the key combinations, and they can set that up. i think that's how Skitch and friends work?

(i.e. start with our own key combination, and let user change it to override default osx one)

[daviddias]

Well, cloudapp, couldup and dropbox capture everything. Custom keyboard shortcut is fine too

[dignifiedquire]

I suggest that by default we capture all screenshots and add a setting where one can disable it.

[daviddias]

I like that @dignifiedquire :)

[bcomnes]

Anyone know how this will interact with other apps capturing screenshots? Dropbox comes to mind.

[jbenet]

I suggest that by default we capture all screenshots and add a setting where one can disable it.

I like that @dignifiedquire :)

i really don't. @whyrusleeping is right -- this is a privacy problem. I think we should do what many other apps do and create a shortcut that you can use (separate), but which you can rebind to override your normal one. That way the user is in control.

eg i have https://github.com/jbenet/ipfs-screencap bound to CMD+SHIFT+2 on OSX

[dignifiedquire]

There is an open PR on electron to make this a whole lot easier: electron/electron#2963 so I suggest we wait for that to be merged.

[hacdias]

What's the state of this issue? Is this feature still wanted? 😄

[hacdias]

Done on #562. The shortcut cmd/ctrl+alt+s is always enabled (was following #31). Should there be an option to activate/deactivate?

[lidel]

Yes, there should be an UI for changing or at least deactivating keyboard shortcuts, otherwise we will make random people sangry (sad+angry 🙃).

(tl;dr will now commence)

When it comes to shortcuts, it is very likely we will run into problems on different platforms / machines.

Combinations that are unused on linux/macOS may be hijacked by default on MS Windows (example: lidel/google-music-hotkeys#3 (comment)) or even by some third party app that "user been running for past 5 years and don't want to change established habits".

A good place too look at for prior-work is the browser extension ecosystem, which had to tackle the same problem, being OS-agnostic. WebExtensions can define keyboard shortcuts as commands in manifest.info in a platform-specific way:

"commands": {
  "toggle-feature": {
    "suggested_key": {
      "default": "Alt+Shift+U",
      "linux": "Ctrl+Shift+U"
    },
    "description": "Send a 'toggle-feature' event to the extension"
  },
  "do-another-thing": {
    "suggested_key": {
      "default": "Ctrl+Shift+Y"
    }
  }
}

On top of that, Google Chrome provides UI for customizing shortcuts
Worth noting that Firefox does not provide UI yet, so user has no choice but to use defaults from manifest.info, thich means developer should be extra conscious about which key combination is picked.

[hacdias]

@lidel unfortunately, Electron doesn't have a way to add different default shortcodes for each operating system. And even when we add a shortcut, it may fail silently if there is already another shortcut with those keys. This way, I cannot know if there is some program already using that shortcut.

Right now I'm only letting the user enable/disable CTRL/CMD+ALT+S for the screenshot. In the future I'll add the option to edit the letter. 😄 What do you think?

[lidel]

Yup, sounds good 👍