Coder Social home page Coder Social logo

Comments (3)

amotl avatar amotl commented on May 20, 2024

Dear @aghster,

thank you so much for watching this closely enough so you have been able to spot this. Shortly after deploying this release, we already recognized spurious exceptions like ValueError: US document number "US2548918" has unexpected length.

You are right, https://github.com/ip-tools/ip-navigator/blob/5f4ec85edbdd6090003aaf87962384693c3ae3ec/patzilla/util/numbers/normalize.py#L390 apparently does not account for padding to 8 digits yet - happy to see you linked to the reference implementation already.

We will try to improve that, thanks again.

Cheers,
Andreas.

from patzilla.

amotl avatar amotl commented on May 20, 2024

@aghster: Should be fixed through f8c4d50 and will become part of the next release.

from patzilla.

amotl avatar amotl commented on May 20, 2024

We can confirm this should be fixed now. You might want to partly validate the outcome by having a look at the corresponding doctests:

Thanks again for spotting this, @aghster!

from patzilla.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.