Coder Social home page Coder Social logo

Comments (11)

sibis avatar sibis commented on May 12, 2024 1

@tarrencev are we updating the docker image anytime now to include this fix?

from ion-sfu.

Sean-Der avatar Sean-Der commented on May 12, 2024 1

Hey @greko6 if you go to https://github.com/orgs/pion you should have an invite to join the org!

If you aren't able to join I will re-open, but hard for me to find bandwidth to help with Ion day-to-day :(

from ion-sfu.

greko6 avatar greko6 commented on May 12, 2024 1

Update based on the Slack thread.

TL;DR most likely we'll need to wait for v3

From Jeremija:
"The main issue here is that in the current version of pion/webrtc the PayloadTypes are defined in the webrtc.MediaEngine and are usually either populated from SDP or defined before any tracks are added. Populating from SDP does not scale well if you need to dynamically add tracks after the first negotiation.
The easiest solution for this is to generate the offers on the server-side and then the browsers will use server-defined PayloadTypes in their answers.
I think there are plans for v3 to fix this behavior."

from ion-sfu.

greko6 avatar greko6 commented on May 12, 2024

Also, this is the reason for the change: https://groups.google.com/forum/#!topic/discuss-webrtc/Z5YOWMC8TwU

It looks like Safari is using WebRTC before M57. Hence the reason why 100, but not 96.

Key quote from that thread: "External apps need to update their code to not rely on hardcoded values. This is all in accordance with the spec, payload types in the range 96-127 are dynamic and are not tied to any specific codec."

Most likely types will change again in the future.

from ion-sfu.

sibis avatar sibis commented on May 12, 2024

@greko6 this issue exists iOS platform mobile and iPad in general. Since even chrome in iphone and ipad uses WebKit rendering engine not V8 just the chrome UI. So any app built on ion-sdk-js is not working on iphone and ipad irrespective of the browser

from ion-sfu.

greko6 avatar greko6 commented on May 12, 2024

I did compile it and created a new docker for my own SFU for testing purposes - after the patch was applied.

Unfortunately, SFU is still not matching it. Here is what I can see:

Offer:
image

Answer:
image

The answer should be:

m=video (...)
(...)
a=rtmpmap: 100 VP8/90000

With 96 Safari is still interpreting the video track as h264.

from ion-sfu.

greko6 avatar greko6 commented on May 12, 2024

Surface Pro tablet is also affected by the same bug. As it's not fixed, can you reopen it, please?

from ion-sfu.

greko6 avatar greko6 commented on May 12, 2024

@tarrencev could you re-open this issue, please? That way people that are using sfu will have much better visibility as it's not working.

from ion-sfu.

greko6 avatar greko6 commented on May 12, 2024

@Sean-Der : This issue, once solved, will allow pion to drastically accelerate as currently, people that are testing it with MacOSes/iPhones/iPads are not getting the streams at all. More recently, I've learned that also Microsoft Surface Pro is affected because of the same simple mismatch reasons.

from ion-sfu.

tarrencev avatar tarrencev commented on May 12, 2024

this is working now but only on ion-sfu not with ion. you can verify it by running ion-sfu with the pub-sub-in-browser example. you will need a reverse proxy for ssl though since safari doesn't like ws

from ion-sfu.

greko6 avatar greko6 commented on May 12, 2024

@tarrencev : Nice! Did you receive a stream on Safari? Which diff fixed it?

from ion-sfu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.