Comments (3)
i think the issue is that when we do Close(), it interally calls delete and which again calls Close so it panics always
https://github.com/pion/ion-sdk-go/blob/master/client.go#L270
https://github.com/pion/ion-sdk-go/blob/1e8126477a4c28444a8b873d63aa6faf37078108/engine.go#L58
from ion-sdk-go.
also client Close should internally Stop the webm producer as well, if its being used
from ion-sdk-go.
I suffer from the same issue.
Client.Close() calls Engine.DelClient() which calls Client.Close() again. This makes panic since it tries to close the closed channel, c.notify here.
Is there any reason that Engine.DelClient() does c.Close() again?
// DelClient delete a client
func (e *Engine) DelClient(c *Client) error {
e.Lock()
if e.clients[c.sid] == nil {
e.Unlock()
return errInvalidSessID
}
/*
if c, ok := e.clients[c.sid][c.uid]; ok && (c != nil) {
c.Close()
}
*/
delete(e.clients[c.sid], c.uid)
e.Unlock()
return nil
}
from ion-sdk-go.
Related Issues (20)
- ion-sdk-go close() HOT 1
- engine client sid issue HOT 1
- new join config issue HOT 1
- Audio is totally distorted when using ion-sfu-load-tool
- ion-sfu-gstreamer-receive sample does not work HOT 2
- Pushing video to the room
- [email protected]/conf.go:10:6: undefined: "github.com/pion/ion-log" HOT 1
- ion-sfu-gstreamer-send video encoding bitrate control HOT 1
- err=rpc error: code = Unavailable desc = connection closed HOT 2
- The ion-cluster-simple can not trigger OnTrack HOT 3
- save-to-webm does't work HOT 1
- ion-sfu-gstreamer-receive does not receive media HOT 5
- Is it possible to mute and unmute the audio using ion sdk go?
- ion-cluster-simple windows gstreamer error: Error: Internal data stream error.
- ion-cluster-simple on windows gstreamer error
- The GST_BUFFER_DURATION function returns GST_CLOCK_TIME_NONE(-1) if the duration is unknown.
- Can I send local track one with webrtc and anther to rtp?
- Please release a new tag and release
- Issue with ScreenShare: a "track" is received, but not its trackevent related "trackevent". HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ion-sdk-go.