Coder Social home page Coder Social logo

Comments (6)

baronfel avatar baronfel commented on July 17, 2024

I think DOTNET_HOST_PATH was required for some msbuild targets/props/shenanigans, so we should require it in some way, but I agree with you that the last-chance fallback of the app name isn't suitable for cases where the caller is in an AppHost and not the dotnet host. I think we can remove that last-chance and raise an exception in the init function if that's the case. That will require callers to set at least one of the valid detection variables, though, which ideally would be represented as an input to the function somehow...

from proj-info.

baronfel avatar baronfel commented on July 17, 2024

One hurdle here is that the .NET SDK doesn't forward any of the environment variables we look for on to local or global tools, like it does for other commands. It might be good to advocate for that feature, because as it stands, tools have no consistent way to detect the dotnet installation that's running them.

from proj-info.

baronfel avatar baronfel commented on July 17, 2024

Talking with some of the SDK team, the DOTNET_ROOT variable is only set if the install location isn't one of the well-known ones. So we should do probing if there's no DOTNET_ROOT.

from proj-info.

baronfel avatar baronfel commented on July 17, 2024

The final algorithm should look something like:

  • DOTNET_HOST_PATH
  • DOTNET_ROOT/DOTNET_ROOT(x86)
  • probe PATH
  • probe default install locations per-OS
  • fail hard if none found

from proj-info.

baronfel avatar baronfel commented on July 17, 2024

@dsyme this was released in 0.55.1

from proj-info.

baronfel avatar baronfel commented on July 17, 2024

@dsyme ok, 0.55.2 has a more sane strategy that doesn't touch DOTNET_HOST_PATH

from proj-info.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.