Coder Social home page Coder Social logo

After removing cordova.js due to "Ionic Deploy" - IPhone status bar overlays header (Same in Ionic view) about legacy-ionic-cloud HOT 17 CLOSED

ionic-team avatar ionic-team commented on May 24, 2024
After removing cordova.js due to "Ionic Deploy" - IPhone status bar overlays header (Same in Ionic view)

from legacy-ionic-cloud.

Comments (17)

imhoffd avatar imhoffd commented on May 24, 2024 2

@sagivf We will be fixing this issue this week. @Fuiste is looking into fixing the deploy plugin so this no longer happens. Ionic View is also being addressed.

from legacy-ionic-cloud.

Fuiste avatar Fuiste commented on May 24, 2024 2

As @Manduro mentioned on the ionic-plugin-deploy repo, I'm currently working on a fix for this wherein the reference to cordova.js is manipulated natively in the plugin rather than in the cloud client. It's still not 100% yet, and I still need to add Android support, but this should be addressed in the coming days.

from legacy-ionic-cloud.

Fuiste avatar Fuiste commented on May 24, 2024 2

Oh, forgot to mention this, but the plugin v0.6.0 was released yesterday, which addresses this problem.

You should no longer need to remove the cordova.js reference now, so feel free to give it a spin!

from legacy-ionic-cloud.

imhoffd avatar imhoffd commented on May 24, 2024 2

@joshgarwood Okay, cool. I'm planning on another release tomorrow that should clear that issue up.

from legacy-ionic-cloud.

imhoffd avatar imhoffd commented on May 24, 2024 1

@sagivf @joshgarwood @Manduro If you update to the latest cloud client and deploy plugin, this issue should be fixed. Remember to add the cordova.js reference back in your index.html.

Let me know how it goes!

from legacy-ionic-cloud.

sagivf avatar sagivf commented on May 24, 2024 1

thanks @dwieeb works nicely!

from legacy-ionic-cloud.

imhoffd avatar imhoffd commented on May 24, 2024

@sagivf I will test this on an iOS device today! Android has thus far been flawless. It could be a number of different issues and we may need to rope some people in to help.

from legacy-ionic-cloud.

sagivf avatar sagivf commented on May 24, 2024

This has something to do with the https://github.com/apache/cordova-plugin-statusbar plugin.
adding <preference name="StatusBarOverlaysWebView" value="false" /> to the config.xml fixed the position issue.

Still haven't solved the color issue though.
Plus its kind of hacky having to do this due to the Ionic Platform...

from legacy-ionic-cloud.

sagivf avatar sagivf commented on May 24, 2024

OK found something else.

Seeing these errors -

image

But when installing the plugin I get a message saying they are already installed.
My guess is that the cordova.js is injected to late, or something like that.

from legacy-ionic-cloud.

imhoffd avatar imhoffd commented on May 24, 2024

@sagivf We verified this yesterday on our devices, by the way. This may require a plugin update. We should not be injecting cordova.js in javascript.

from legacy-ionic-cloud.

sagivf avatar sagivf commented on May 24, 2024

You mean you verified that it works? Not sure I follow. Is there a change on the way which will address this? Is there a workaround in the meantime?

from legacy-ionic-cloud.

imhoffd avatar imhoffd commented on May 24, 2024

Sorry, I meant that we're also getting the status bar issue. I'm looking at our options right now.

from legacy-ionic-cloud.

Manduro avatar Manduro commented on May 24, 2024

This is not only happening for statusbar or splashscreen, but for any cordova plugin. Still, for the statusbar you can use the following config setting as a workaround to prevent the statusbar from overlapping the header:

const ionicConfig = {
  platforms: {
    ios: {
      statusbarPadding: true
    }
  }
};

ionicBootstrap(App, providers, ionicConfig);

from legacy-ionic-cloud.

imhoffd avatar imhoffd commented on May 24, 2024

@Manduro Yep, the problem is just an order-of-operations issue with how we're loading cordova.js. The status bar is just the most immediate and obvious thing that's broken.

from legacy-ionic-cloud.

joshgarwood avatar joshgarwood commented on May 24, 2024

@Fuiste any update on the fix for this and when it will be generally available? Thanks for knocking this out, by the way!

from legacy-ionic-cloud.

imhoffd avatar imhoffd commented on May 24, 2024

Next week I will be testing and prepping the cloud client with the new version of the deploy plugin.

This should be resolved soon so we can get this stuff out the door!

from legacy-ionic-cloud.

joshgarwood avatar joshgarwood commented on May 24, 2024

Thanks @dwieeb !! I recently upgrade to Ionic 2 Beta 11, and there's a peer dependency issue with Angular RC.4. I noticed the Issue created here, so unfortunately I don't think I can upgrade cloud angular until that issue is resolved.

from legacy-ionic-cloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.