Coder Social home page Coder Social logo

Comments (8)

mcm1957 avatar mcm1957 commented on August 17, 2024

Maybe the default should be adjusted too
Or the size / appearance of the 'x' should be adjusted.

In general one feature of jsonConfig is that UI is displayed somehow constistent over mutliple adapters. Too much variants will eventually disturb this goal and result in questins "Clear button missing".

I confirm, that the X is not optimal at black design. But I think we should check what style guide we want.

(In addtion I wonder why the numeric fields seem to be text fields ...)

from iobroker.admin.

tp1de avatar tp1de commented on August 17, 2024

(In addtion I wonder why the numeric fields seem to be text fields ...)

These fields are hex numbers not decimal and can contain letters as well.

from iobroker.admin.

GermanBluefox avatar GermanBluefox commented on August 17, 2024

you can use noClearButton as true to hide the clear button from 6.17.13

from iobroker.admin.

tp1de avatar tp1de commented on August 17, 2024

you can use noClearButton as true to hide the clear button from 6.17.13

Thanks a lot. I will finally test when 6.17.13 is released.
With version 12 it is already working (adapter config dialog) but with warnings about invalid jsonConfig within log.

from iobroker.admin.

tp1de avatar tp1de commented on August 17, 2024

Even with 6.17.13 the warning message within log exists:

ems-esp has an invalid jsonConfig: [{"instancePath":"/items/tab-ems-esp/items/ems_modulation","schemaPath":"#/additionalProperties","keyword":"additionalProperties","params":{"additionalProperty":"noClearButton"},"message":"must NOT have additional properties"},{"instancePath":"/items/tab-ems-esp/items/ems_modulation","schemaPath":"#/patternProperties/%5E.%2B/allOf/21/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match \"then\" schema"},{"instancePath":"/items/tab-ems-esp","schemaPath":"#/properties/items/patternProperties/%5E.%2B/allOf/8/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match \"then\" schema"},{"instancePath":"","schemaPath":"#/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match \"then\" schema"}]

from iobroker.admin.

tp1de avatar tp1de commented on August 17, 2024

And I would recommend to set noClearButton as default without adding this attribute explicitly.
(Layout is fine now, but the warning should disappear)

from iobroker.admin.

mcm1957 avatar mcm1957 commented on August 17, 2024

@tp1de

Even with 6.17.13 the warning message within log exists:

ems-esp has an invalid jsonConfig: [{"instancePath":"/items/tab-ems-esp/items/ems_modulation","schemaPath":"#/additionalProperties","keyword":"additionalProperties","params":{"additionalProperty":"noClearButton"},"message":"must NOT have additional properties"},{"instancePath":"/items/tab-ems-esp/items/ems_modulation","schemaPath":"#/patternProperties/%5E.%2B/allOf/21/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match \"then\" schema"},{"instancePath":"/items/tab-ems-esp","schemaPath":"#/properties/items/patternProperties/%5E.%2B/allOf/8/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match \"then\" schema"},{"instancePath":"","schemaPath":"#/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match \"then\" schema"}]

The new attribute seems to be missing from schema used for checking.
Please open a Issue here:
https://github.com/ioBroker/adapter-react-v5/issues/new?assignees=foxriver76&labels=schema+%3Abook%3A&projects=&template=schema.yml&title=%5BjsonConfig%5D%3A+

from iobroker.admin.

tp1de avatar tp1de commented on August 17, 2024

ioBroker/adapter-react-v5#337

from iobroker.admin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.