Comments (17)
Dann schließe ich dieses Problem mal da alle Probleme bereits in Merges bearbeitet werden.
Vielen Dank @LarsK1
from invoiceninja.
@LarsK1 are we factoring in discounts with the calculations?
from invoiceninja.
@turbo124 yes we we're, but in x invoice 3.0 the schema changed. The fix is already available in #9523
from invoiceninja.
@support-tt please check, once the next release is ready.
from invoiceninja.
@LarsK1 I will do that thanks
from invoiceninja.
@LarsK1
Hello I tested this today sorry for the delay I was ill and then had some stress. The fields are now correct but there is a new issue.
The field:
Version v5.8.55
GrossPriceProductTradePrice was correct in version 5.8.55
<ram:GrossPriceProductTradePrice>
<ram:ChargeAmount>1000.00</ram:ChargeAmount>
</ram:GrossPriceProductTradePrice>
In the new Version v5.10 (with 5% discount):
<ram:GrossPriceProductTradePrice>
<ram:ChargeAmount>1005.00</ram:ChargeAmount>
<ram:AppliedTradeAllowanceCharge>
<ram:ChargeIndicator>
<udt:Indicator>false</udt:Indicator>
</ram:ChargeIndicator>
<ram:ActualAmount>100.0</ram:ActualAmount>
</ram:AppliedTradeAllowanceCharge>
</ram:GrossPriceProductTradePrice>
we tested this the ChargeAmount actuelly adds +5€ to the invoice. So our invoice is 1000 and the field is 1005 (instead of 5% discount the price here is higher then the whole invoice without tax).
from invoiceninja.
Hi @support-tt ,
can you please send me an example invoice, so that I can clearly test your case.
from invoiceninja.
Rechnung_R0031.pdf
Rechnung_R0032.pdf
Attached are 2 PDF with embedded XML (xinvoice 2.2). Unfornetetely I cant upload XML here. In both example we got 5€ and 20 € discount (with percentage discount its the same so when you got 5% discount the XML adds 5€ to ChargeAmount ) and this discound got added to the ChargeAmount in GrossPriceProductTradePrice
Thanks @LarsK1
edit: here is an example with percent discount.
Rechnung_R0031_Percent.pdf
from invoiceninja.
Hi @support-tt,
I took the same data as you provided in your examples. And generated the both attached xinvoice files. There the calculcation is absolutly correct. You can also validate any invoice (using XInvoice 3.0.1) here: https://e-rechnung.bayern.de/app/#/upload
My demo files:
Invoice_PtPWT.zip
Can you please try to set your profile to the latest XInvoice, then regenerate these files and then recheck? (It migth be an issue with older profiles)
from invoiceninja.
Hello @LarsK1 ,
we switched to XInvoice 2.2 because we need the XML embedded in the PDF (german goverment needs).
So I tested with 2.2. Can I change the minor version like 2.2.1 ?
from invoiceninja.
Hi @support-tt ,
ZUGFeRD ist auch in Version 3.0.1 unterstützt. Alle andern Versionen sind eh rechtlich gesehen nicht (mehr) gültig. Die anderen Versionen werden auch bald entsprechend entfernt...
from invoiceninja.
Hi @LarsK1
wie wähle ich denn Version 3.0.1 aus ?
Wenn ich 3.0 auswähle bekomme ich in der Mail das XML und PDF einzeln. Leider wurde uns gesagt, dass wir nur 1 Anhang schicken dürfen und dieser muss PDF mit XML embedded sein oder nur XML.
Da wir Kunden haben die natürlich das PDF haben wollen war 2.2 mit PDF embedded die ideale Lösung.
Habe ich hier etwas übersehen ?
Also mit dem Haken Merge E-Invoice bekomme ich das PDF mit XML aber auch das XML nochmal einzeln. Das wird leider von unseren Staatskunden abgelehnt da nur 1 anhang zugelassen ist -,-
from invoiceninja.
Wir haben aber gerade mit der Invoice 3.0 Version nochmal geprüft und der Wert "ChargeAmount in GrossPriceProductTradePrice" ist bei uns leider immer noch Falsch in der neuesten Version. Wir benutzen die Stock Docker Version ohne Anpassungen. Er Addiert hier den Rabat als Wert auf.
Hier ein Beispiel mit Invoice 3.0
Rechnung_R0032.pdf
Die Rechnung ist 1710 mit 10 % Rabat im XML steht
<ram:GrossPriceProductTradePrice> <ram:ChargeAmount>1720.00</ram:ChargeAmount>
Zusatz:
Hattest du mal mit prozentualen Rabatten getestet ?
from invoiceninja.
Ah, jetzt verstehe ich wo der Fehler liegt. Die Option für nur PDF ohne XML ist heute in's Repo gemergt worden. Sollte also im nächsten Release verfügbar sein. Das andere schaue ich mir bald an.
from invoiceninja.
@support-tt ,
bitte probiere mal diese Änderung in: app/Services/EDocument/Standards/ZugferdEDokument.php in Zeile 147:
von:
$this->xdocument->addNewPosition($index)
->setDocumentPositionGrossPrice($item->gross_line_total + $item->discount)
->setDocumentPositionNetPrice($item->line_total);
auf
$this->xdocument->addNewPosition($index)
->setDocumentPositionGrossPrice($item->gross_line_total)
->setDocumentPositionNetPrice($item->line_total);
Danach die Datei speichern und die E-Rechnung erneut herunterladen.
Let me know, how it goes.
from invoiceninja.
@LarsK1
Mit dieser Änderung ist die Rechnung mit Invoice3.0 richtig.
Mit der Änderung das nur das PDF geschickt wird ist es dann perfekt :)
from invoiceninja.
Alles klar. Danke für das Feedback. Die Änderungen sind im PR #9777, sobald der Release dazu da ist, sollte dieser Fehler auch weg sein.....
from invoiceninja.
Related Issues (20)
- Quote approval process is out of order.
- $xxx must not be accessed before initialization - Jobs stuck in queue HOT 14
- Change numbers of invoice in bulk
- Feature Request: Recurring invoices -option to allow merge to a single invoice
- invoiceninja.zip is missing in latets release HOT 1
- Health Check should check for php extensions HOT 1
- Wrong formatting in "Reports" view and CSV-exports.
- Feature request: more custom fields
- Password reset for Admin user, was NOT logged out everywhere or at all HOT 2
- Laravel Workers not able to restart HOT 2
- Apply choosen tax rate on surcharge, even with line item taxes HOT 2
- UBL_invoice composer update and composer install zip error [updated[ HOT 1
- Allow Expenses to be added to existing Invoice rather tham creating a new one
- [Feature Request] Start Tasks with Kanban View
- One-Page Checkout error HOT 1
- New user unable to set password on https docker install HOT 1
- Update Custom Fields in quotes and invoices when settings change
- Queue error: After Ubuntu Version update (and PHP update) HOT 2
- Duplicate recurring invoice
- Add Group Variable to quote or invoice
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from invoiceninja.