Coder Social home page Coder Social logo

Comments (3)

inukshuk avatar inukshuk commented on June 6, 2024 1

Can you try with the latest changes? I've added checking for the minimum unspecified range.

If the reported edtf strings work as expected we could leave it as is, or, perhaps better normalize it, by resetting the result to the minimum always. Currently, when unspecified masks are in play, there is no normalized fixed point for each interval. For example, if you parse '201X' the parser will set the year to 2010, but because of the mask the real range is 2010-2019. A date with the same mask and the year set to 2016 would cover the same 'unspecified range'. Currently, using next will push you to the minimum of the next range and prev will push you to the maximum of the previous range.

from edtf.js.

inukshuk avatar inukshuk commented on June 6, 2024

Thanks, you're right! We currently expand the unspecified 'range' to its maximum (i.e., to 2019 in this example), but we need to use the minimum when subtracting.

from edtf.js.

SylvainBigonneau avatar SylvainBigonneau commented on June 6, 2024

Can you try with the latest changes? I've added checking for the minimum unspecified range.

Thanks, it works great on my side!

If the reported edtf strings work as expected we could leave it as is, or, perhaps better normalize it, by resetting the result to the minimum always. Currently, when unspecified masks are in play, there is no normalized fixed point for each interval. For example, if you parse '201X' the parser will set the year to 2010, but because of the mask the real range is 2010-2019. A date with the same mask and the year set to 2016 would cover the same 'unspecified range'. Currently, using next will push you to the minimum of the next range and prev will push you to the maximum of the previous range.

I don't have much of an opinion on this, I personally avoid using the builtin date methods, especially on unspecified dates...

from edtf.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.