Coder Social home page Coder Social logo

Comments (3)

jwtodd avatar jwtodd commented on August 19, 2024

@vinodtalati the following lines in [ws]/bin/fpm.sh fail on osx where users do not specify JAVA_HOME:

export JAVA_HOME=${JAVA_HOME:-/usr/local/java}
export PATH=$JAVA_HOME/bin:$PATH

q: are these lines required for all supported environments?

if so, then for OSX we should set the default value to /usr/libexec/java_home

q: if we do have to set JAVA_HOME then does /usr/libexec/java_home exist on linux?

i am hoping we can remove explicitly setting JAVA_HOME :)

from wasabi.

vinodtalati avatar vinodtalati commented on August 19, 2024

@jwtodd This should be removed.

The path /usr/libexec/java_home doesn't exit on linux. This is only for mac.
The Ubuntu patch we added does everything required for Linux inside the bootstrap method (in wasabi.sh). For Mac the JAVA_HOME was never set anywhere. It could be added to bootstrap as well.

In any case the lines you mentioned in fpm.sh should not be there.

from wasabi.

jwtodd avatar jwtodd commented on August 19, 2024

ok thx @vinodtalati i will spin up a PR

much appreciated!

from wasabi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.