Comments (3)
Yeah, I was promoting that myself quite a bit.
It's just so tempting to have the ILP packet be "account, amount and data."
The justification would be that the ILP packet always talks about the destination, so destinationAccount, destinationAmount and destinationData would be sorta redundant.
Don't feel strongly either way.
from ilp-packet.
The packet format should be account
and data
but I think the JS interface for this module could accept either those names or the names with the destination
prefix, if that makes it more consistent with the rest of the JS implementation.
from ilp-packet.
I think this issue can be closed now @sharafian
from ilp-packet.
Related Issues (19)
- consider moving typeString to a separate static function HOT 1
- should packet.data really be length-prefixed? HOT 2
- The name 'fulfillment' is ambiguous HOT 1
- Use default values and validate parameters HOT 1
- Run integration tests on this repo?
- IlpReject incompatible with ASN.1 definition HOT 2
- Add a function to parse the account and amount without the data HOT 1
- allow reading and writing extensions HOT 1
- Accept and return trailing bytes HOT 6
- GeneralizedTime is not C-OER compliant HOT 10
- An in-range update of @types/node is breaking the build 🚨 HOT 29
- An in-range update of oer-utils is breaking the build 🚨 HOT 3
- An in-range update of codecov is breaking the build 🚨 HOT 6
- ILP v1 compatible release HOT 3
- An in-range update of @types/mocha is breaking the build 🚨 HOT 1
- An in-range update of @types/chai is breaking the build 🚨 HOT 2
- OER encoding of GeneralizedTime HOT 1
- Add function to parse any packet type
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ilp-packet.