Coder Social home page Coder Social logo

Comments (2)

JoblersTune avatar JoblersTune commented on July 16, 2024

@mkurapov

  1. I believe we need to collect the number of prepare packets as they arrive at a node and the number of fulfill and reject responses that same node is sending back. I.e. I don't think we want to collect the number of fulfill or reject responses that are received at a node, we want to collect the number of fulfill or reject responses that a node sends. The reason for this is that if you see your example above, if A keeps sending multiple requests to C, but only C has telemetry enabled we're gonna be collecting high numbers of prepares but absolutely no fulfill or reject packet counts.
  2. In the scheme above, where we collect incoming prepares and outgoing fulfills/rejects then the collectTelemetryAmount metric is already correctly positioned, so that it aligns with all occassions where we send a fulfill response. So for this bullet point: "packet_amount_fulfill (treat the amount as we do now: we need to convert it to a base currency, see the current collectTelemetryAmount function for this)" Are you just asking me to change the name of the metric to packet_amount_fulfill? Because all of this logic is already at the packet level.

from rafiki.

mkurapov avatar mkurapov commented on July 16, 2024

@JoblersTune

  1. I think that makes sense - keeping the sending & receiving of packets for telemetry "self-contained" within a node/connector. One of the metrics we wanted to track was network loss, meaning we could calculate how many packets were lost by doing Number of packets - (2 * (rejected + fulfilled)) = “network loss”, but as long as we still collecting the fulfill/reject count increase after the HTTP request (in general, at the end of the middleware chain(, we should still get the same behaviour.

  2. Yes, I think it makes sense to just rename the metric. The tricky part right now is to figure out the placement of it - currently, I think the way that it's placed the metric is collected twice during a fulfill packet - once in the receiving connector and another time in the sending connector.

from rafiki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.