Comments (2)
- I believe we need to collect the number of prepare packets as they arrive at a node and the number of fulfill and reject responses that same node is sending back. I.e. I don't think we want to collect the number of fulfill or reject responses that are received at a node, we want to collect the number of fulfill or reject responses that a node sends. The reason for this is that if you see your example above, if A keeps sending multiple requests to C, but only C has telemetry enabled we're gonna be collecting high numbers of prepares but absolutely no fulfill or reject packet counts.
- In the scheme above, where we collect incoming prepares and outgoing fulfills/rejects then the
collectTelemetryAmount
metric is already correctly positioned, so that it aligns with all occassions where we send a fulfill response. So for this bullet point: "packet_amount_fulfill (treat the amount as we do now: we need to convert it to a base currency, see the current collectTelemetryAmount function for this)" Are you just asking me to change the name of the metric topacket_amount_fulfill
? Because all of this logic is already at the packet level.
from rafiki.
-
I think that makes sense - keeping the sending & receiving of packets for telemetry "self-contained" within a node/connector. One of the metrics we wanted to track was network loss, meaning we could calculate how many packets were lost by doing
Number of packets - (2 * (rejected + fulfilled)) = “network loss”
, but as long as we still collecting the fulfill/reject count increase after the HTTP request (in general, at the end of the middleware chain(, we should still get the same behaviour. -
Yes, I think it makes sense to just rename the metric. The tricky part right now is to figure out the placement of it - currently, I think the way that it's placed the metric is collected twice during a fulfill packet - once in the receiving connector and another time in the sending connector.
from rafiki.
Related Issues (20)
- Add additional parameters to the Wallet Address
- Implement End-to-End Testing for Admin UI
- Track transaction time per outgoing payment
- Track network/conversion fees
- Allow `createWalletAddress` mutation to take in additional properties
- Allow `updateWalletAddress` mutation to take in additional properties
- Treat rates as composite exchange and network rates
- [BUG] Internal Server Error on Interact Redirect URL
- Cannot send from asset scale 2 to asset scale 9
- Review TigerBeetle integration based on current TigerBeetle release HOT 1
- Admin UI payments page does not save type filter when navigating across pages HOT 2
- Update Webhook Documentation (config, retries)
- Improve Admin UI for Managing Incoming Auth Tokens with Editable Dropdown
- Fix minimum delivery amounts HOT 1
- Add documentation for hosting Kratos on a sub domain HOT 1
- Performance Testing
- Add Webhook Enum to Admin API
- Create better docs for Admin UI and its auth
- [BUG] The settings page is not loading for the Admin UI
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rafiki.