Coder Social home page Coder Social logo

Comments (2)

tla avatar tla commented on June 24, 2024

I put this fix on a branch because it does change the API a little. Collation.add_witness now takes a dict structure that looks (coincidentally enough) like the JSON specification of a witness (whether pretokenized or not). I have added a method, Collation.add_plain_witness, that preserves the old behaviour, and I've changed the tests to use that instead. If you (@rhdekker) think the fix is fine, then you can merge it to master and close this.

from collatex.

rhdekker avatar rhdekker commented on June 24, 2024

Fix is fine, the responsibilities are better distributed over the classes in the patch. Merged into master.

from collatex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.