Coder Social home page Coder Social logo

Comments (4)

hellsan631 avatar hellsan631 commented on July 24, 2024
client.conversations.list()

you need to send in an empty object

client.conversations.list({})

should work

from intercom-node.

kmiyashiro avatar kmiyashiro commented on July 24, 2024

@hellsan631 thanks, I actually figured it out in my update 😄. I'm keeping this issue here since I recommended either putting this in the docs or default it to {} if nothing is passed. At the very least, a helpful error should throw.

from intercom-node.

RuairiK avatar RuairiK commented on July 24, 2024

Thanks for the update, we'll look at adding this to our docs.

from intercom-node.

hellsan631 avatar hellsan631 commented on July 24, 2024

This should perhaps be changed:

https://github.com/intercom/intercom-node/blob/master/lib/conversation.js

 list(data, f) {
    return this.client.get('/conversations', data, f);
  }

into (or something like that)

list(data, f) {
  return this.client.get('/conversations', data || {}, f);
}

from intercom-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.