Comments (10)
Hi @pcothenet
Thanks for getting in touch. We're still very much developing this lib, and we're hopeful we can get it to something everyone really loves using.
Re. your first point, would you mind checking out this diff? #18
from intercom-node.
That looks way better yes! (I don't think the doc is up-to-date though).
No worries, I'm actually super happy that you guys are building an official library. Happy to help!
from intercom-node.
@pcothenet docs updated with a note about calllbacks https://www.npmjs.com/package/intercom-client
from intercom-node.
👍 for what @pcothenet said. If you're going to expose callback-style functions, it should really follow node-style callbacks. The great part of this is users of the API can even integrate things like Bluebird's promisify() with their code to wrap your library if the convention is followed :D
from intercom-node.
@tejasmanohar when you say "node-style" are you referring to promises too? I may split out promises into another issue and close this to reduce confusion if so.
from intercom-node.
@bobjflong Nope, not at all. function(err, result)
= node-style callbacks. My comment on Bluebird was related to Bluebird's promisify method which only works for node-style callbacks. Anyhow, node-style is the way to go due to convention :) - I have a few points of feedback on this repo and will send PRs soon.
from intercom-node.
@tejasmanohar but the callbacks currently support the form function(err, result)
- see #18
from intercom-node.
Ah ok perfect, sorry, I was looking at the wrong thing. Thanks for clarifying, @bobjflong! I would recommend opening another issue for promises as well then as this is a bit misleading in title.
from intercom-node.
Done here: #45 I will likely add this today
from intercom-node.
Thanks, @bobjflong! Till then, users should be able to promisify this using a module like Bluebird or an independent one on NPM to get the same end result :)
from intercom-node.
Related Issues (20)
- Make CreateCompanyData fields optional HOT 4
- Documentation Error HOT 2
- Unable to pass customAttribute object to client.conversation.update() HOT 1
- Typo in type `RecepientType` (should be RecipientType) HOT 2
- I can not create a contact user. HOT 8
- Try to run boiler plate code in a node script either results in "SyntaxError: Cannot use import statement outside a module" or "Error [ERR_MODULE_NOT_FOUND]" HOT 1
- Unable to update by companyId with `client.companies.update`
- Type issue while using Intercom-Version headers HOT 1
- Small mistake in README - "import { Client } from './dist/index';" HOT 1
- Get Converting circular structure to JSON error when init Client
- How to import types ? HOT 1
- Unexpected behaviour using access token HOT 2
- Creating and Updating a Company - only companyId should be required
- Searching conversations with date fields always returns an empty result
- Do not throw undefined when the response body does not match the intercom API format
- Axios dependency version has critical vulnerability CVE-2023-45857 HOT 2
- createDataAttribute returns a 500
- ERROR | Unexpected error when using the `search` query on the `post` method HOT 1
- Intercom migration guide is missing HOT 1
- #2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from intercom-node.