Comments (3)
Yeah, thanks @janmeier for documenting this. I just ran into this today. Javascript error handling is already pretty terrible. Let's not add to terror!
Think of the typical user scenario...
client.users.find({ user_id: 'my_nonexistent_user' })
.then((response) => {
// Business logic that potentially throws
})
.catch((error) => {
try {
const statusCode = JSON.parse(error.message).statusCode;
// handle statusCode
}
catch(parseError) {
// I guess it was an issue with the business logic?
}
});
from intercom-node.
In the meantime, it would be useful to document current behavior. It's unexpected that an error message property is a JSON string.
from intercom-node.
Hi @janmeier and @sderickson
thanks for this, that seems valid, and like you said I think for a first step might be good document this so that it is clear how you can access the error attributes.
I will try and get to this as a first step
Thanks
Cathal
from intercom-node.
Related Issues (20)
- Unable to pass customAttribute object to client.conversation.update() HOT 1
- Typo in type `RecepientType` (should be RecipientType) HOT 2
- I can not create a contact user. HOT 8
- Try to run boiler plate code in a node script either results in "SyntaxError: Cannot use import statement outside a module" or "Error [ERR_MODULE_NOT_FOUND]" HOT 1
- Unable to update by companyId with `client.companies.update`
- Type issue while using Intercom-Version headers HOT 1
- Small mistake in README - "import { Client } from './dist/index';" HOT 1
- Get Converting circular structure to JSON error when init Client
- How to import types ? HOT 1
- Unexpected behaviour using access token HOT 2
- Creating and Updating a Company - only companyId should be required
- Searching conversations with date fields always returns an empty result
- Do not throw undefined when the response body does not match the intercom API format
- Axios dependency version has critical vulnerability CVE-2023-45857 HOT 2
- createDataAttribute returns a 500
- ERROR | Unexpected error when using the `search` query on the `post` method HOT 1
- Intercom migration guide is missing HOT 1
- #2
- Unable to build 5.0.0 with TypeScript HOT 1
- `listAttachedTags` Method has wrong return type HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from intercom-node.