Coder Social home page Coder Social logo

Comments (3)

csaroff avatar csaroff commented on July 24, 2024 3

Yeah, thanks @janmeier for documenting this. I just ran into this today. Javascript error handling is already pretty terrible. Let's not add to terror!

Think of the typical user scenario...

client.users.find({ user_id: 'my_nonexistent_user' })
.then((response) => {
  // Business logic that potentially throws
})
.catch((error) => {
  try {
    const statusCode = JSON.parse(error.message).statusCode;
    // handle statusCode 
  }
  catch(parseError) {
    // I guess it was an issue with the business logic?
  }
});

from intercom-node.

sderickson avatar sderickson commented on July 24, 2024 1

In the meantime, it would be useful to document current behavior. It's unexpected that an error message property is a JSON string.

from intercom-node.

choran avatar choran commented on July 24, 2024

Hi @janmeier and @sderickson
thanks for this, that seems valid, and like you said I think for a first step might be good document this so that it is clear how you can access the error attributes.
I will try and get to this as a first step
Thanks
Cathal

from intercom-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.