Coder Social home page Coder Social logo

Add a port file to vcpkg? about hexl HOT 8 CLOSED

intel avatar intel commented on August 27, 2024 1
Add a port file to vcpkg?

from hexl.

Comments (8)

WeiDaiWD avatar WeiDaiWD commented on August 27, 2024 1

No pressure. I was just describing what is supported when installing via vcpkg. SEAL does not support windows dynamic either. :)

from hexl.

fboemer avatar fboemer commented on August 27, 2024

Thanks for the tip! This would be a nice feature; we'll take a look.

from hexl.

WeiDaiWD avatar WeiDaiWD commented on August 27, 2024

Let me know if I can help.

from hexl.

WeiDaiWD avatar WeiDaiWD commented on August 27, 2024

I took the liberty of adding "hexl" to vcpkg, See pull request.
We want to add "building APSI with HEXL enabled" to Microsoft/APSI's readme. Since we recommend building dependencies of APSI via vcpkg, we need HEXL to be there. :)

There are requirements in vcpkg that makes this PR really difficult. I'm working on it. Basically, HEXL's downloading cpu-features is not allowed in vcpkg, since the better way is to install cpu-features from vcpkg and to call find_package(CpuFeatures ...) in HEXL. But cpu-features installed by vcpkg has an issue too, which make find_package(CpuFeatures ...) fail all the time. I might have to add patches to both packages.

Anyway, nothing requires any change in HEXL so far. This is likely to be approved next week.

from hexl.

fboemer avatar fboemer commented on August 27, 2024

I took the liberty of adding "hexl" to vcpkg, See pull request.
We want to add "building APSI with HEXL enabled" to Microsoft/APSI's readme. Since we recommend building dependencies of APSI via vcpkg, we need HEXL to be there. :)

There are requirements in vcpkg that makes this PR really difficult. I'm working on it. Basically, HEXL's downloading cpu-features is not allowed in vcpkg, since the better way is to install cpu-features from vcpkg and to call find_package(CpuFeatures ...) in HEXL. But cpu-features installed by vcpkg has an issue too, which make find_package(CpuFeatures ...) fail all the time. I might have to add patches to both packages.

Anyway, nothing requires any change in HEXL so far. This is likely to be approved next week.

Thanks, @WeiDaiWD! Let us know if you need any support from the hexl side.

from hexl.

WeiDaiWD avatar WeiDaiWD commented on August 27, 2024

FYI, two minor things that I've noticed:

  • cmake/HEXLConfig.cmakeis not ignored.
  • HEXLConfig.cmake, HEXLConfigVersion.cmake, HEXLTargets.cmake, and HEXLTargets-release.cmake are installed to /usr/local/lib/cmake rather than /usr/local/lib/cmake/HEXL (or better /usr/local/lib/cmake/HEXL-1.1).

These are unrelated to this issue. :)

from hexl.

WeiDaiWD avatar WeiDaiWD commented on August 27, 2024

Finally we have hexl added to vcpkg, this PR is merged. So now you can install hexl with ./vcpkg install hexl. On Windows, you have to use ./vcpkg install hexl:x64-windows-static or ./vcpkg install hexl:x64-windows-static-md. The reason why dynamic linking won't work on Windows is that HEXL does not export symbols.

I'm gonna add an option to install SEAL with HEXL enabled to vcpkg, e.g., ./vcpkg install seal[hexl] soon.

from hexl.

fboemer avatar fboemer commented on August 27, 2024

Thanks, @WeiDaiWD! We'll see if we can fix the Windows dynamic build.

from hexl.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.