Coder Social home page Coder Social logo

Comments (5)

dest81 avatar dest81 commented on July 19, 2024 10

With react-router 2.8.1 works fine, but it would be good if react-router-active-component works with react 3.0.0 too :)

from react-router-active-component.

JProgrammer avatar JProgrammer commented on July 19, 2024

@mayerwin Have you upgraded to react router 3.0? I don't think react-router-active-component supports this new major version yet

from react-router-active-component.

mayerwin avatar mayerwin commented on July 19, 2024

According to my package.json file, I am using 3.0 (I just did jspm install react-router), but as per the link I indicated previously, it seems to be related to Bootstrap passing props to its children (they say it is the responsibility of child components to forget about them).
I was able to make it work by wrapping the element returned by activeComponent with another one which sole purpose is to filter out the props ["active", "activeKey", "activeHref"].

let NavItem2 = activeComponent('li');

function objectWithout(obj, keys) {
    let target = {};
    Object.keys(obj).forEach(k => {
        if (keys.indexOf(k) == -1) {
            target[k] = obj[k];
        }
    });
    return target;
}

const NavItem = (props) => {
    return React.createElement(NavItem2, objectWithout(props, ["active", "activeKey", "activeHref"]));
};

from react-router-active-component.

JProgrammer avatar JProgrammer commented on July 19, 2024

Could you try downgrading to react-router 2.8.1 and see if this is still the issue?

from react-router-active-component.

mayerwin avatar mayerwin commented on July 19, 2024

I can try, but isn't it possible for react-router-active-component to enforce a dependency version (were it to work, it would be quite a brittle solution)?

from react-router-active-component.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.