Coder Social home page Coder Social logo

Comments (5)

inorganik avatar inorganik commented on August 27, 2024 2

There are unit tests and manual tests that I run on every release of CountUp.js. This angular wrapper is downstream of CountUp and although I have put great effort into keeping everything bug free for every possible use-case, things like this will get through occasionally.

Also keep in mind that this is free, open source software and I am NOT responsible for your production app. Instead be thankful that I dropped what I was doing and quickly responded and fixed the issue.

from ngx-countup.

inorganik avatar inorganik commented on August 27, 2024

Thanks for the issue. I just changed the build in v2.6.1 of countup, so if you can somehow pin countUp to 2.6.0, it will solve this issue.

It's because rollup insists on re-writing this to either undefined or window when in the global scope, and typescript adds a polyfill for Object.assign that uses this in the global scope. Before it was rewriting it to undefined, I think that's preferable, so I will have to revert that change and publish another patch.

from ngx-countup.

inorganik avatar inorganik commented on August 27, 2024

run npm install again, and it should pick up the latest version of CountUp (2.6.2) which reverts that change to use window.

from ngx-countup.

Clashsoft avatar Clashsoft commented on August 27, 2024

Thanks. For pnpm, I had to run pnpm update because mere install does not change transitive dependency versions (as it should).

from ngx-countup.

Clashsoft avatar Clashsoft commented on August 27, 2024

In the future, please test breaking changes like this, especially when releases as a patch version (!). This broke our production app.

from ngx-countup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.