Comments (5)
There are unit tests and manual tests that I run on every release of CountUp.js. This angular wrapper is downstream of CountUp and although I have put great effort into keeping everything bug free for every possible use-case, things like this will get through occasionally.
Also keep in mind that this is free, open source software and I am NOT responsible for your production app. Instead be thankful that I dropped what I was doing and quickly responded and fixed the issue.
from ngx-countup.
Thanks for the issue. I just changed the build in v2.6.1 of countup, so if you can somehow pin countUp to 2.6.0, it will solve this issue.
It's because rollup insists on re-writing this
to either undefined
or window
when in the global scope, and typescript adds a polyfill for Object.assign
that uses this
in the global scope. Before it was rewriting it to undefined, I think that's preferable, so I will have to revert that change and publish another patch.
from ngx-countup.
run npm install
again, and it should pick up the latest version of CountUp (2.6.2) which reverts that change to use window.
from ngx-countup.
Thanks. For pnpm
, I had to run pnpm update
because mere install does not change transitive dependency versions (as it should).
from ngx-countup.
In the future, please test breaking changes like this, especially when releases as a patch version (!). This broke our production app.
from ngx-countup.
Related Issues (20)
- Cannot update endVal and options simultanously HOT 1
- How to reset countup js? HOT 2
- Performance Improvements using zone.js HOT 3
- Extend peer dependencies to Angular 8 HOT 2
- Uncaught SyntaxError: Unexpected token export HOT 7
- Start animation when element is scrolled or is visible in viewport HOT 3
- How to add a style? HOT 1
- Error on server side rendering HOT 10
- 'kind' of undefined HOT 2
- angular 9 HOT 2
- NG build --prod failing due to "cannot read 'kind' of undefined" HOT 1
- Can't bind to 'endVal' HOT 5
- Angular 10 HOT 1
- Bugs: Wrong switching to new animation during old HOT 1
- Does not build with Angular 10 HOT 7
- Angular 13 HOT 1
- Make the animate function public HOT 2
- Angular 15 compability HOT 4
- This likely means that the library (ngx-countup) which declares CountUpModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-countup.