Coder Social home page Coder Social logo

Comments (6)

albertchon avatar albertchon commented on July 18, 2024

This actually is hard to implement correctly on the exchange API side since the new orders which get fully filled aren't detected by the exchange indexer... is that okay @maximshen007

from injective-helix-demo.

maximshen007 avatar maximshen007 commented on July 18, 2024

ok, that is fine. Can we at least show traders all the historical order updates except for those fully filled orders? what about those cancelled/rejected orders?

from injective-helix-demo.

bangjelkoski avatar bangjelkoski commented on July 18, 2024

@albertchon we can fetch these if we query for the cancelled state on the OrdersRequest, right?

from injective-helix-demo.

albertchon avatar albertchon commented on July 18, 2024

Not by default as those orders are garbage collected after 5 min currently. Rejected orders never make it to the blockchain so aren't recorded in the history. Only orders that successfully enter the blockchain trigger an event which then gets indexed.

Still, I'm not sure how necessary order history is for now. Maybe for the future.

from injective-helix-demo.

bangjelkoski avatar bangjelkoski commented on July 18, 2024

Not by default as those orders are garbage collected after 5 min currently. Rejected orders never make it to the blockchain so aren't recorded in the history. Only orders that successfully enter the blockchain trigger an event which then gets indexed.

Still, I'm not sure how necessary order history is for now. Maybe for the future.

Got it. Labeling the issue as stale for now.

from injective-helix-demo.

albertchon avatar albertchon commented on July 18, 2024

Closing this issue for now since it'll be quite some time until we can consider implementing this, if even at all

from injective-helix-demo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.