MarkPrice Threshold Check about injective-helix-demo

[albertchon]

@bangjelkoski what formula(s) for order validations does the FE currently apply? Can you link to the code?

[bangjelkoski]

There are a couple of validations we do on the FE:

• Form validation (checking whether we have amount + price for limit orders),
• Whether there are enough fillable orders to fill the order,
• Whether the amount we want to fill is too big i.e there is no enough liquidity in the order book,
• Whether the user has enough balance/margin to make the order, https://github.com/InjectiveLabs/injective-dex/blob/39eea7a015bdee3420fecb359b9f3acecbcf7b26/components/partials/spot/trading/trade.vue#L416

also, additionally for derivatives:

• Whether the user can use the leverage the requested or its too high https://github.com/InjectiveLabs/injective-dex/blob/39eea7a015bdee3420fecb359b9f3acecbcf7b26/components/partials/derivatives/trading/trade.vue#L522
• Whether the reduce only exceeded the maxReduceOnly https://github.com/InjectiveLabs/injective-dex/blob/39eea7a015bdee3420fecb359b9f3acecbcf7b26/components/partials/derivatives/trading/trade.vue#L484

@albertchon

[achilleas-kal]

I replicated multiple times, the first four criteria were satisfied and the last (not exceed maxReduceOnly) was irrelevant in my case as I had no open positions at the time.

Indeed, this occurs only when the leverage factor is set high. To replicate, attempt to open a position with 10x or 20x leverage, any amount will produce this error.

Maybe modify Bugsnag config to be able to trace errors in all releaseStages?

[bangjelkoski]

I could replicate the issue mentioned above. The error appears when we broadcast the transaction to the injective-exchange. /cc @albertchon

[bangjelkoski]

We need to add validation on the UI level to prevent this issue for happening, namely:

// For Buys: MarkPrice ≥ (Margin - Price * Quantity) / ((InitialMarginRatio - 1) * Quantity)
// For Sells: MarkPrice ≤ (Margin + Price * Quantity) / ((1+ InitialMarginRatio) * Quantity)