Comments (7)
I'm a bit reluctant about this.
PyOAI is a very old stable library with many users, so adding a dependency is a big step.
Are there any specific usecases you are thinking about?
from pyoai.
@jayvdb , python3-compatible release is out, would you like to submit a patch for urllib3 or requests? We could have a look.
from pyoai.
I think it'd be great to use requests
, definitely more standard nowadays and it's true, it should simplify the codebase. @jayvdb any interest in making a PR? I believe this one would need good test coverage and so on, more work than most of the other todos in this repo right now
from pyoai.
Sorry, I am not working in this area at the moment, and have a full plate on other OSS projects right now.
from pyoai.
My vote: get the current small stuff merged in and released, and keep this issue open as something that could be tried out later (ie. for next major release, if there ever needs to be one). If @jascoul says he'd accept a PR that refactors to use requests
wherever possible, I'd consider doing this when I had some free time, as I totally agree that requests module is superior to urllib stuff in every way, and is definitely the norm for modern projects now. But long story short, if things work fine as is, prio for a big refactor with high potential for breaking changes should not be super high
from pyoai.
IDK if my vote counts, but unless the code gets way shorter and way more readable, I would refrain from relying on another 3rd party library, even as widespread as requests
.
from pyoai.
Definitely a valid perspective (and it's not like I suddenly own this repo, so I guess it's for the others to decide)! Anyway, there's a list of things to do before this one, so it can get tabled for now. But in my experience you'd be surprised how nice requests can make some old urllib code :)
Plus it's all academic unless those who can merge say they'd accept the PR anyway, no point writing anything till confirmation of that exists.
So yeah, low low prio right now if nothing's broken with urllib.
And requests is really only 'technically' a third party module at this point 😃
from pyoai.
Related Issues (20)
- Python3 support not in PyPI HOT 11
- There's no bdist_wheel version on pypi
- from_ and until arguments throw error HOT 1
- RDF and ORE Support HOT 1
- Error in makeRequestErrorHandling from a listRecords call with from_ parameter HOT 4
- Create o modify the fields of metadata HOT 2
- XML parse errors parsing metadata payload HOT 1
- Declared Python objects should override __repr__ HOT 1
- 504 Gateway Time-out
- Reading metadata results HOT 2
- pyoai health / maintenance status? HOT 19
- Migrate from Travis to GitHub actions
- remove interfaces.py (RFC) HOT 2
- How to create readers for other OAI Metadata Schemas?
- Description in setup.py should be a single line HOT 1
- Fix CI
- The 2.5.1 version is not available in Pypi?
- cqi.parse_qs deprecated
- Loop over all records ? HOT 6
- Limit request rate
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyoai.