[inputs.upsd] Inconsistent output type for multi-state variables containing "enabled"/"disabled" about telegraf

[srebhan]

@powersj the problem here is that the plugin wants to be too clever as it will detect enabled and disabled strings and convert them to booleans. However, there are multiple non-binary strings also containing other things like muted... So again auto-typing bites us. :-(

The correct way would be to not do any auto-type conversions for strings, but this certainly breaks backward compatibility...

@masterwishx you might use the enum processor to convert the value. Here an untested suggestion

[[processors.enum]]
  [[processors.enum.mapping]]
    field = "ups_beeper_status"
    default = false
    [processors.enum.mapping.value_mappings]
      enabled = true
      disabled = false
      muted = false

[srebhan]

@masterwishx we will discuss this with the team to see what's the best way forward... Will come back to you next week.

[srebhan]

@masterwishx we discussed within the team and think the best way forward is to document the current behavior including an example of how to convert back the booleans to strings using the enum processor.

The reason for not trying to "solve" it in code is because the issue comes from the underlying library that is out of our control. Even if we are trying to be smart and convert the booleans back to strings we will break existing users. So there is really nothing we can do here. :-(

[srebhan]

@masterwishx please check if the documentation in #14938 is comprehensible! :-)

[powersj]

So if influxdata has already written the value as a boolean, then you need to continue to pass it as a boolean.

[srebhan]

@masterwishx or you convert / drop the existing series containing the booleans...

[masterwishx]

@masterwishx or you convert / drop the existing series containing the booleans...

Sure , i made new bucket ,working fine . also will try maybe to convert/drop old data ...

[masterwishx]

from https://networkupstools.org/docs/developer-guide.chunked/apas02.html

[masterwishx]

it seems error appear when muted instead of enabled or disabled

[masterwishx]

@srebhan @powersj can you please check this out ....

[powersj]

I did not think we did any transformation of enabled/disabled to true or false. Were you using another collector before?

@masterwishx can you set dump_raw_variables = false please I want to see an entry with both a disabled/enabled and one with muted.

[masterwishx]

I did not think we did any transformation of enabled/disabled to true or false. Were you using another collector before?

@masterwishx can you set dump_raw_variables = false please I want to see an entry with both a disabled/enabled and one with muted.

Do you mean to test on windows? I was tested on windows befor...
I can check disabled/muted enabled somehow not working for me now becose of some kind of bug in upsd, when I set enabled it's goes to mute value but in real the sound is working so it's enabled

[masterwishx]

@powersj

disabled:

mute:

[powersj]

In line protocol false and true are booleans, not strings. As a result, your very first value was probably either false or true and InfluxDB went "that's a boolean". Then you sent a "muted" string, which InfluxDB rejects becuase of the type conflict.

My suggestion is for you to is to use a processor in telegraf to convert the values to booleans, and/or drop your data and use a processor to convert them all to strings. For the first, you could use the strings processor to match on "muted" and change it to true/false.

@srebhan any other thoughts?

[masterwishx]

In line protocol false and true are booleans, not strings. As a result, your very first value was probably either false or true and InfluxDB went "that's a boolean". Then you sent a "muted" string, which InfluxDB rejects becuase of the type conflict.

My suggestion is for you to is to use a processor in telegraf to convert the values to booleans, and/or drop your data and use a processor to convert them all to strings. For the first, you could use the strings processor to match on "muted" and change it to true/false.

@srebhan any other thoughts?

can you give an example for it please?

[masterwishx]

@powersj @srebhan this should be as global variable? like this or inside the [[inputs.upsd]] ?

[masterwishx]

@powersj the problem here is that the plugin wants to be too clever as it will detect enabled and disabled strings and convert them to booleans. However, there are multiple non-binary strings also containing other things like muted... So again auto-typing bites us. :-(

The correct way would be to not do any auto-type conversions for strings, but this certainly breaks backward compatibility...

@masterwishx you might use the enum processor to convert the value. Here an untested suggestion

[[processors.enum]]
  [[processors.enum.mapping]]
    field = "ups_beeper_status"
    default = false
    [processors.enum.mapping.value_mappings]
      enabled = true
      disabled = false
      muted = false

Yes , This Working fine ... but if it possible to convert to string like : enabled ,disabled,muted ?

[masterwishx]

@masterwishx please check if the documentation in #14938 is comprehensible! :-)

Working Fine ,Thanks

[masterwishx]

@srebhan @powersj its not working in 1.29.5 ?

[masterwishx]