Comments (3)
I thought I'd squash the error message cause by breaking inside a conditional. I originally planned to switch the conditional logic but then I came to wonder if you still mean for sed to delete PLG_DATACHECK line if found in the cfg file? I ask as a vanilla install of the plugin writes PLG_DATACHECK="yes" to the cfg file, so I'm thinking perhaps the deletion is/was a legacy thing?
from unplugged.
Actually not sure how that all got back in, could have sworn I had removed it.When I added the "force update" option it hit the limit of the update.htm for passing variables so I had to remove one. I chose to remove the option to toggle the data check off/on. The deletion of PLG_DATACHECK from the cfg is actually to remove the line from the config for people who are coming from older versions where it was needed. I guess I either forgot to remove it being written in a vanilla install and checking for it before calling the datacheck function, or I merged the change with an older version somewhere along the way.
Your pull request essentially would do the same thing as removing the if condition from around the call to the datacheck function. We should fix the break but removing the checks to the config for that variable would be the ideal way. I'll pull this for now until we can remove the old code
from unplugged.
Sorry, didn't realize it wasn't a PR. :p
from unplugged.
Related Issues (17)
- LazyLibrarian HOT 5
- SABNZBD stop function not working
- Newznab installation fails
- OpenSSL-0.9.8 should be updated
- on CouchPotato ThePirateBay search does not work HOT 1
- Broken link for logo for headphones
- Heaphones Version Issue HOT 13
- Couchpotato won't update in-app HOT 1
- Gamez branch old, use lad1337 HOT 1
- Plugin for XDM (eXtendable Download Manager) HOT 4
- HTPC-Manager: Switch to mainline repository. HOT 1
- Add Unrar to SB package.
- Python related issues in NZBMegasearcH
- PlexMediaServer Watchdog Plugin HOT 1
- Sabnzbd is messed up HOT 3
- LazyLibrarian HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unplugged.