Coder Social home page Coder Social logo

Comments (11)

tabrindle avatar tabrindle commented on June 9, 2024 2

I think this should fix it. infinitered/solidarity-react-native#30

This was my bad. Upgraded envinfo in solidarity but not its usage in this plugin. 🤦‍♂️

from solidarity.

GantMan avatar GantMan commented on June 9, 2024 2

Yup!

So in solidarity-react-native located here: https://github.com/infinitered/solidarity-react-native

All the code for checking is here: https://github.com/infinitered/solidarity-react-native/blob/master/extensions/react-native.js

I hope this helps. Feel free to ask questions as you get started.

from solidarity.

kaushal9678 avatar kaushal9678 commented on June 9, 2024 2

As @tabrindle mentioned above you can change following lines of code in directory

1st file to modify

node_module/solidarity-react-native/react-native.js

add **await ** before getAndroidEnvData

check: async (rule, context) => {
          const {
            androidAppGradle,
            availableApiVersions,
            availableBuildToolsVersions,
            projectApiVersion,
            projectBuildToolsVersion
          } = await  getAndroidEnvData(context); 

2nd place to add in same file

report: async (rule, context, report) => {
          const { print } = context;
          const { colors } = print;
          const {
            androidAppGradle,
            availableApiVersions,
            availableBuildToolsVersions,
            projectApiVersion,
            projectBuildToolsVersion
          } = await getAndroidEnvData(context);

2nd File to Modify

node_module/solidarity-react-native/helpers/getAndroidEnvData.js
changes these lines

 availableApiVersions: androidData["API Levels"],
      availableBuildToolsVersions: androidData["Build Tools"],

like following

availableApiVersions: androidData[1]["API Levels"],
 availableBuildToolsVersions: androidData[1]["Build Tools"],

from solidarity.

Pushplaybang avatar Pushplaybang commented on June 9, 2024

@tabrindle @kevinvangelder I'm still experiencing this issue with the following deps:

   "solidarity": "^2.3.1",
   "solidarity-react-native": "^2.1.2"

from solidarity.

is343 avatar is343 commented on June 9, 2024

I'm also still getting this.

   "solidarity": "^2.3.1",
   "solidarity-react-native": "^2.1.2"

I've got my android sdk path setup in ./android/local.properties

the Android section of my snapshot is reading as:


    "Android": [
      {
        "rule": "env",
        "variable": "ANDROID_HOME",
        "error": "The ANDROID_HOME environment variable must be set to your local SDK.  Refer to getting started docs for help."
      },
      {
        "rule": "custom",
        "plugin": "React Native",
        "name": "androidVersion"
      }
    ],

Solidarity is spitting out this error:

✖ The ANDROID_HOME environment variable must be set to your local SDK.  Refer to getting started docs for help.
✖ ./android/app/build.gradle not found

Solidarity checks failed.
error Command failed with exit code 1.

If I remove the Android section from the snapshot, everything passes, but that's obviously a less than ideal solution.

from solidarity.

GantMan avatar GantMan commented on June 9, 2024

Sorry for the delay on this. I'll be trying to take a look at this whenever I can.

I don't think that the current code actually adheres to local.properties, but it wouldn't be hard to add it if not. Would you be interested in adding that code? I'd be happy to assist you. If not, I'll keep it on my TODO, and update when I can take care of it.

from solidarity.

is343 avatar is343 commented on June 9, 2024

@GantMan sure, I can do that. Would you mind helping me get started by pointing to where the logic is, or a general idea on what needs to be done?

from solidarity.

loiclouvet avatar loiclouvet commented on June 9, 2024

Thanks @kaushal9678. Should we merge this ?

from solidarity.

FrederickEngelhardt avatar FrederickEngelhardt commented on June 9, 2024

Will this be fixed?

from solidarity.

GantMan avatar GantMan commented on June 9, 2024

Would you like to send the PR? As long as it passes the tests, we can merge.

from solidarity.

anfriis avatar anfriis commented on June 9, 2024

Thanks, this fix works for me as well 👍🏼

from solidarity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.