[Bug] Inertia Route macro does not work with Route Parameters about inertia-laravel

[peterfox]

@sebastiandedeyne sure I'll try and fit in some time to take a look

[sebastiandedeyne]

This looks like a bug to me. @peterfox any chance you could do a follow up PR that fixes this? 😇

[peterfox]

It's really weird this behaviour seems to happen with Macros but doesn't happen with the router view method that does literally the same thing.

The following code for the controller I believe fixes the issue. I have a feeling this might be related to the Laravel version as well, it looks like the controller for Route::view has changed in L6, it might just be a cosmetic reason for changing though. @marvinrabe are you using Laravel 6?

<?php

namespace Inertia;

use Illuminate\Http\Request;

class Controller
{
    public function __invoke(Request $request)
    {
        return Inertia::render(
            $request->route()->defaults['component'],
            $request->route()->defaults['props']
        );
    }
}

[marvinrabe]

@peterfox No, I am still on Laravel 5.8. Haven't tested it with Laravel 6 yet.

[marvinrabe]

@peterfox It seems like injecting parameters in controller methods is always done by order. See the documentation:

Route parameters are injected into route callbacks / controllers based on their order - the names of the callback / controller arguments do not matter.

Up until now I did not know this. I find this quite unintuitive. I opened a feature proposal for changing this behaviour.

[Lelectrolux]

@marvinrabe

I find this quite unintuitive

It allows you to do this :

// matches 'GET /1/my-article-slug'
Route::get('/{writer}/{article_slug}', function(Writer $writer, Article $article) {
    // Here I can use $article instead of $article_slug/$articleSlug
});