Coder Social home page Coder Social logo

Comments (6)

fish-dango avatar fish-dango commented on August 11, 2024

I can try to take a crack at this !

from starfish.

danisyellis avatar danisyellis commented on August 11, 2024

That would be great. Thanks fish-dango! Let me know if you have any questions.

from starfish.

danisyellis avatar danisyellis commented on August 11, 2024

@fish-dango are you still planning to work on this? It's been a few months and I haven't heard anything. No worries if you're too busy, just let us know because someone else might be excited to try it as a Hacktoberfest project.
(If we don't hear back from Fish by a week from now (October 8th) I'd say it's fair for someone else to pick it up.)

from starfish.

ak2ie avatar ak2ie commented on August 11, 2024

May I take charge of this issue?

I am considering the following responses

  1. Add IGNORE_REPOSITORY_IDS to .env.template.
  2. Create a function to filter events.

Thank you in advance for your cooperation.

from starfish.

kevindigo avatar kevindigo commented on August 11, 2024

Hi @ak2ie!

The primary maintainer is out this week, so I'll jump in to try to help.

You mentioned adding an IGNORE_REPOSITORY_IDS setting, which sounds like a different feature than what was proposed. This issue requested the ability to ignore repos based on who owns them, rather than specifying individual repos directly. Did you intend to propose this different feature? If so, would you find it useful yourself, or are you just hoping to improve Starfish for others?

Also, I believe repos have internal "id" values that show up in API calls. I'm thinking we would want to identify repos by their group/name (indeedeng/starfish), in which case the field probably shouldn't have IDS in the name. So maybe IGNORE_REPOSITORIES would be better, and then the docs would have to describe what format the list of repo identifiers would have to conform to.

Let us know what you think.

Kevin

from starfish.

ak2ie avatar ak2ie commented on August 11, 2024

Hi Kevin.

Thank you for your confirmation.

It seems that my understanding was insufficient and my thinking was incorrect.
I would like to add the ability to ignore repos based on the repo owner.

I would like to add IGNORE_REPOSITORIES to the .env.template.

I will give it some more thought.

Thank you in advance for your help with the above.

from starfish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.