Comments (15)
- csv file format for spectrometer
- Separate files for RF and Gradients and a way to combine them and delay periods
from pypulseq.
@tonggehua For gradient waveforms, pypulseq
has the seq.gradient_waveforms()
method. Let me know if that's sufficient for gradient waveforms.
from pypulseq.
@sravan953
Right now, everyone will have to write their own code for outputting the entire waveforms. It would be valuable to have an inbuilt method for it. Plus, it might just be a simple modification from seq.plot().
from pypulseq.
@tonggehua If you have a seq
object, call seq.gradient_waveforms()
to get the gradient waveforms across the three channels. Does that clarify what the method does?
from pypulseq.
@sravan953 It does output the entire gradient waveforms. So what we need is adding on the RF, ADC, and uniform timing across. Thanks!
from pypulseq.
@tonggehua Yes, thanks for confirming! Will work on the RF and ADC. Could you elaborate on what you mean by 'uniform timing'? Thanks again.
from pypulseq.
I would not recommend uniform timing. I would recommend event-based timing. I do not see value in having times for delays (0s), only start and stop should suffice. If we need a common time clock, that will run at 1us and can be quite lengthy and redundant.
from pypulseq.
@sairamgeethanath For compression and storage, uniform timing is definitely not efficient. The feature I am suggesting is having flattened outputs that share the same time vector for (1) easy plotting and (2) benchmarking (comparing one sequence to another) purposes.
from pypulseq.
@tonggehua Not efficient for plotting too. I need two endpoints to connect and make a straight line. Even from a console standpoint, you just sample value and HOLD until it changes: either for writing or for reading.
from pypulseq.
@sairamgeethanath @sravan953 For the .seq waveform output feature, I would like to use it for more robust benchmarking of seq2xml. JEMRIS's output is uniformly timed across RF, G, and ADC. I would like to be able to compare the .h5 output and seq.output_waveforms(), say, directly. Having the same time resolution (maybe Δt should be user-specifiable) helps.
from pypulseq.
@tonggehua @sravan953 This feature needs to return two outputs: one should be in the format compatible with JEMRIS (@tonggehua please share a sample for gre with @sravan953 ). The other output should be compatible with the console needs of event-based logging only.
from pypulseq.
@tonggehua Commit f36f91a contains an updated waveforms_and_times()
method -
pypulseq/pypulseq/Sequence/sequence.py
Line 1096 in cc4aa8d
Let me know if it's what you were looking for?
from pypulseq.
@sravan953 It seems to do the same thing; I will try plotting with this function and get back to you. Please do consider my pull-request (#62) as it also has the feature of specifying the time range before generating the waveforms.
from pypulseq.
@tonggehua Alright will wait for your feedback.
from pypulseq.
PR #62 takes care of this, closing!
from pypulseq.
Related Issues (20)
- unused variable HOT 3
- np.int and np.float HOT 1
- AttributeError when calling calculate_kspace() in sequence.py HOT 2
- CI Tests HOT 1
- Cannot generate trapezoidal gradient only specifying amplitude and duration. HOT 1
- Arguments of make_block_pulse are highly confusing HOT 3
- make_trapezoid with just flat_area fails HOT 6
- Conda Package for Pypulseq HOT 5
- PyPulseq requires GPU compute (cuPy) on Google Colab HOT 2
- KeyError When Reading .seq File generated from MATLAB pulseq 1.4.0 in pypulseq 1.4.0 HOT 5
- Pypulseq ignores BlockDurationRaster Definition in file
- Compatibility with Pulseq 1.3.1 broken HOT 1
- Feature: Sequence `install`
- Sigpy pulses can not be added to sequence HOT 1
- add_blocks interpolation issue HOT 2
- "Identical" shapes not found in event_lib HOT 4
- Numpy float error when importing pypulseq HOT 1
- Change default branch back to main HOT 1
- Incompatibility of sigpy dependency with scipy 1.14.0 and numpy 2.0 HOT 1
- block duration rounding assertion test HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pypulseq.