Sigpy==0.1.23 incompatible with numpy>1.20 about pypulseq

[wtclarke]

It looks like there is already some progress on this with sigpy mikgroup/sigpy#123 and mikgroup/sigpy#126

[btasdelen]

@wtclarke Thanks for reporting this. We can update the sigpy version as soon as they merge the fix and release it.

I agree with your suggestion. I have never used CI, would you be willing to open a PR for a .yml file for this project? Is that even how it works? 😄

[schuenke]

I am currently preparing a pypulseq hands-on session for this friday and installing PyPulseq is really a pain in the a**

Can we please push a hotfix to master and release a version 1.40.post1?
The only thing we have to do is change the dependencies from "sigpy==0.1.23" to "sigpy>=0.1.25"
We can still discuss to remove the sigpy dependency completely in the future, but for now we need a quick solution IMO!

EDIT:
the sigpy developers merged the fix in May, but didn't release it yet. Thus, changing to "sigpy>=0.1.25" is NOT enough yet.

A temporary option would be to change the dependency to git+https://github.com/mikgroup/sigpy.git, but this would prohibit a release to PyPi. Still it might be the best option for the moment?

[wtclarke]

This is fixed with the merge of #148

[schuenke]

Is there a reason why we ask for sigpy==0.1.23 and not >= 0.1.23 ?

We should at least push a fix for the imcompatibility problem to the dev branch, but I could imagine that a lot of users that are not on GitHub get frustrated due to this issue and maybe even stop using PyPulseq...

So imo we should fix this and release v1.40.post1 as soon as possible!!!

[btasdelen]

@schuenke We can do that. Or, we can remove the sigpy dependency, as we are only using a couple of functions from a single file. With appropriate copyright notice of course. How about it?