Coder Social home page Coder Social logo

Improve install_deps.sh about illixr HOT 5 CLOSED

illixr avatar illixr commented on July 21, 2024
Improve install_deps.sh

from illixr.

Comments (5)

mhuzai avatar mhuzai commented on July 21, 2024 1

Yes, I agree that a more automated approach would be best but given our limited resources, what we have at the moment is alright.

As for the printing behavior, I think we're in agreement.

from illixr.

e3m3 avatar e3m3 commented on July 21, 2024

For the package dependencies, we can print all packages to be sent to 'apt-get'. 'apt-get' subsequently shows which packages will actually be installed. Another option is to find out which packages will be installed by 'apt-get' using the provided package list, and print that instead.

For the other install scripts, 'cmake' is generally used to build the packages, followed by a 'make install'. What is the correct behavior for these dependencies? We already prompt the user asking whether each dependent library should be installed.

from illixr.

mhuzai avatar mhuzai commented on July 21, 2024

The original intent of this was that we should tell the user what the intent of the script is before we start prompting them for individual dependencies. This would be more detailed information than just "install DBoW2?" It would say what we need DBoW2 for, for instance.
But this may be unnecessary now. The queries give enough high-level information, and if we print the apt packages, that might be sufficient. Open to ideas.

What did you think was lacking in install_deps when you ran it?

from illixr.

e3m3 avatar e3m3 commented on July 21, 2024

Based on what you said, I could see us printing a list containing the relevant name for each prompt, and then subsequently do the prompts.

Regarding the apt packages, the package list is currently printed after the user prompt, but before installation (without an additional prompt). Given the current structure of the install scripts, this behavior is okay with me.

In general, I dislike prompts in scripts, but I could see the need for them for ILLIXR users. If the result of the large dependency list is that the project is tied to a handful of Ubuntu LTS distributions only, then I would say a more automated approach that detects missing/conflicting packages or sets up a virtual environment would be best.

from illixr.

charmoniumQ avatar charmoniumQ commented on July 21, 2024

If we're already printing the packages that apt-get installs, I'd suggest also silencing the stdout. It's pretty redundant, anything significant goes to stderr, and I care about the signal-to-noise ratio of the script, so warnings do not get missed.

from illixr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.